public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Adhemerval Zanella <azanella@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc] elf: Remove _dl_skip_args
Date: Mon, 30 May 2022 20:50:27 +0000 (GMT)	[thread overview]
Message-ID: <20220530205027.792C2384B82E@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=81e7fdd7ccff3745db0b0d8ffa1ec9fab6dcee67

commit 81e7fdd7ccff3745db0b0d8ffa1ec9fab6dcee67
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Thu May 26 13:15:56 2022 -0300

    elf: Remove _dl_skip_args
    
    Now that no architecture uses it anymore.
    
    Reviewed-by: Carlos O'Donell <carlos@redhat.com>

Diff:
---
 elf/rtld.c                    | 2 --
 sysdeps/generic/ldsodefs.h    | 4 ----
 sysdeps/mach/hurd/dl-sysdep.c | 1 -
 3 files changed, 7 deletions(-)

diff --git a/elf/rtld.c b/elf/rtld.c
index 069940d73f..f5a3d1968f 100644
--- a/elf/rtld.c
+++ b/elf/rtld.c
@@ -158,8 +158,6 @@ static void process_envvars (struct dl_main_state *state);
 
 int _dl_argc attribute_relro attribute_hidden;
 char **_dl_argv attribute_relro = NULL;
-/* Always 0, only kept for not-yet-updated target start code.  */
-const unsigned int _dl_skip_args attribute_hidden;
 rtld_hidden_data_def (_dl_argv)
 
 #ifndef THREAD_SET_STACK_GUARD
diff --git a/sysdeps/generic/ldsodefs.h b/sysdeps/generic/ldsodefs.h
index 6716e1f382..446d12a68c 100644
--- a/sysdeps/generic/ldsodefs.h
+++ b/sysdeps/generic/ldsodefs.h
@@ -755,10 +755,6 @@ rtld_hidden_proto (__libc_stack_end)
 extern int _dl_argc attribute_hidden attribute_relro;
 extern char **_dl_argv attribute_relro;
 rtld_hidden_proto (_dl_argv)
-#if IS_IN (rtld)
-/* Always 0, only kept for not-yet-updated target start code.  */
-extern const unsigned int _dl_skip_args attribute_hidden;
-#endif
 #define rtld_progname _dl_argv[0]
 
 /* Flag set at startup and cleared when the last initializer has run.  */
diff --git a/sysdeps/mach/hurd/dl-sysdep.c b/sysdeps/mach/hurd/dl-sysdep.c
index 8373962e62..f23fdee058 100644
--- a/sysdeps/mach/hurd/dl-sysdep.c
+++ b/sysdeps/mach/hurd/dl-sysdep.c
@@ -139,7 +139,6 @@ _dl_sysdep_start (void **start_argptr,
 	    mach_port_t memobj;
 	    error_t err;
 
-	    ++_dl_skip_args;
 	    --_dl_argc;
 	    p = _dl_argv++[1] + 1;


                 reply	other threads:[~2022-05-30 20:50 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220530205027.792C2384B82E@sourceware.org \
    --to=azanella@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).