From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1791) id A7D9F385DC03; Fri, 3 Jun 2022 14:08:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A7D9F385DC03 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Adhemerval Zanella To: glibc-cvs@sourceware.org Subject: [glibc/azanella/clang] string: Suppress clang -Wsuspicious-bzero on tester X-Act-Checkin: glibc X-Git-Author: Adhemerval Zanella X-Git-Refname: refs/heads/azanella/clang X-Git-Oldrev: bf00caf9488cc6125e71709be8f7ec57e798ee16 X-Git-Newrev: 3a98e467bda0f18f85ec9127d58423ab3e686659 Message-Id: <20220603140853.A7D9F385DC03@sourceware.org> Date: Fri, 3 Jun 2022 14:08:53 +0000 (GMT) X-BeenThere: glibc-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Glibc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jun 2022 14:08:53 -0000 https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=3a98e467bda0f18f85ec9127d58423ab3e686659 commit 3a98e467bda0f18f85ec9127d58423ab3e686659 Author: Adhemerval Zanella Date: Thu Mar 24 18:08:41 2022 -0300 string: Suppress clang -Wsuspicious-bzero on tester Diff: --- string/tester.c | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/string/tester.c b/string/tester.c index eed76239f5..46a24e7417 100644 --- a/string/tester.c +++ b/string/tester.c @@ -370,28 +370,48 @@ test_strncat (void) mechanism. */ it = "strncat"; (void) strcpy (one, "ijk"); + /* clang complains that size argument is too large for the destination + buffer. */ + DIAG_PUSH_NEEDS_COMMENT_CLANG; + DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wfortify-source"); check (strncat (one, "lmn", 99) == one, 1); /* Returned value. */ + DIAG_POP_NEEDS_COMMENT_CLANG; equal (one, "ijklmn", 2); /* Basic test. */ (void) strcpy (one, "x"); + DIAG_PUSH_NEEDS_COMMENT_CLANG; + DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wfortify-source"); (void) strncat (one, "yz", 99); + DIAG_POP_NEEDS_COMMENT_CLANG; equal (one, "xyz", 3); /* Writeover. */ equal (one+4, "mn", 4); /* Wrote too much? */ (void) strcpy (one, "gh"); (void) strcpy (two, "ef"); + DIAG_PUSH_NEEDS_COMMENT_CLANG; + DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wfortify-source"); (void) strncat (one, two, 99); + DIAG_POP_NEEDS_COMMENT_CLANG; equal (one, "ghef", 5); /* Basic test encore. */ equal (two, "ef", 6); /* Stomped on source? */ (void) strcpy (one, ""); + DIAG_PUSH_NEEDS_COMMENT_CLANG; + DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wfortify-source"); (void) strncat (one, "", 99); + DIAG_POP_NEEDS_COMMENT_CLANG; equal (one, "", 7); /* Boundary conditions. */ (void) strcpy (one, "ab"); + DIAG_PUSH_NEEDS_COMMENT_CLANG; + DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wfortify-source"); (void) strncat (one, "", 99); + DIAG_POP_NEEDS_COMMENT_CLANG; equal (one, "ab", 8); (void) strcpy (one, ""); + DIAG_PUSH_NEEDS_COMMENT_CLANG; + DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wfortify-source"); (void) strncat (one, "cd", 99); + DIAG_POP_NEEDS_COMMENT_CLANG; equal (one, "cd", 9); (void) strcpy (one, "ab"); @@ -404,7 +424,10 @@ test_strncat (void) (void) strncat (one, "gh", 2); equal (one, "abcdgh", 12); /* Count and length equal. */ + DIAG_PUSH_NEEDS_COMMENT_CLANG; + DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wfortify-source"); (void) strncat (one, "ij", (size_t)-1); /* set sign bit in count */ + DIAG_POP_NEEDS_COMMENT_CLANG; equal (one, "abcdghij", 13); int ntest = 14; @@ -1408,7 +1431,12 @@ test_bzero (void) equal(one+4, "ef", 3); (void) strcpy(one, "abcdef"); + + DIAG_PUSH_NEEDS_COMMENT_CLANG; + /* clang complains about the 0 size argument for bzero. */ + DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wsuspicious-bzero"); bzero(one+2, 0); + DIAG_POP_NEEDS_COMMENT_CLANG equal(one, "abcdef", 4); /* Zero-length copy. */ }