public inbox for glibc-cvs@sourceware.org help / color / mirror / Atom feed
From: Adhemerval Zanella <azanella@sourceware.org> To: glibc-cvs@sourceware.org Subject: [glibc/azanella/clang] posix: Suppress clang warning on bug-regex24 Date: Fri, 3 Jun 2022 14:09:39 +0000 (GMT) [thread overview] Message-ID: <20220603140939.51C993850857@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=2a5d49699119ba191c1712d86605216e13fb6894 commit 2a5d49699119ba191c1712d86605216e13fb6894 Author: Adhemerval Zanella <adhemerval.zanella@linaro.org> Date: Fri Mar 25 11:23:35 2022 -0300 posix: Suppress clang warning on bug-regex24 clang complains that adding a 'regoff_t' to a string doe snot append to it, and the printf idea below is to make rm_so an offset. Diff: --- posix/bug-regex24.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/posix/bug-regex24.c b/posix/bug-regex24.c index 97c5c3508a..7a655cbc4d 100644 --- a/posix/bug-regex24.c +++ b/posix/bug-regex24.c @@ -1,6 +1,7 @@ #include <regex.h> #include <stdio.h> #include <string.h> +#include <libc-diag.h> #define str "civic" @@ -45,11 +46,17 @@ do_test (void) { int len = m[i].rm_eo - m[i].rm_so; + /* clang complains that adding a 'regoff_t' to a string does not + append to it, and the printf idea below is to make rm_so as + an offset to str. */ + DIAG_PUSH_NEEDS_COMMENT_CLANG; + DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wstring-plus-int"); printf ("m[%d] = \"%.*s\"\n", i, len, str + m[i].rm_so); if (strlen (expected[i]) != len || memcmp (expected[i], str + m[i].rm_so, len) != 0) result = 1; + DIAG_POP_NEEDS_COMMENT_CLANG; } return result;
next reply other threads:[~2022-06-03 14:09 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-03 14:09 Adhemerval Zanella [this message] -- strict thread matches above, loose matches on Subject: below -- 2024-04-17 20:10 Adhemerval Zanella 2024-04-02 15:56 Adhemerval Zanella 2024-02-09 17:35 Adhemerval Zanella 2024-02-07 14:10 Adhemerval Zanella 2024-01-29 18:00 Adhemerval Zanella 2023-12-21 18:57 Adhemerval Zanella 2023-09-28 17:55 Adhemerval Zanella 2023-08-30 12:39 Adhemerval Zanella 2023-02-09 19:51 Adhemerval Zanella 2022-10-28 17:44 Adhemerval Zanella 2022-10-04 13:02 Adhemerval Zanella 2022-06-09 21:23 Adhemerval Zanella 2022-06-09 13:20 Adhemerval Zanella 2022-05-13 14:23 Adhemerval Zanella 2022-05-12 19:37 Adhemerval Zanella 2022-05-10 18:27 Adhemerval Zanella 2022-04-29 14:07 Adhemerval Zanella 2022-04-04 12:57 Adhemerval Zanella 2022-03-31 19:10 Adhemerval Zanella 2022-03-29 20:33 Adhemerval Zanella
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220603140939.51C993850857@sourceware.org \ --to=azanella@sourceware.org \ --cc=glibc-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).