From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 7829) id 5085639490B0; Tue, 7 Jun 2022 18:32:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5085639490B0 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Matheus Castanho To: glibc-cvs@sourceware.org Subject: [glibc/release/2.35/master] powerpc: Fix VSX register number on __strncpy_power9 [BZ #29197] X-Act-Checkin: glibc X-Git-Author: Matheus Castanho X-Git-Refname: refs/heads/release/2.35/master X-Git-Oldrev: fe9ca732ace94cb49e4d4846a4492db40cde34e4 X-Git-Newrev: 0a1572b8bb880a63d50a63b2afe4bb67704ac23e Message-Id: <20220607183222.5085639490B0@sourceware.org> Date: Tue, 7 Jun 2022 18:32:22 +0000 (GMT) X-BeenThere: glibc-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Glibc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jun 2022 18:32:22 -0000 https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=0a1572b8bb880a63d50a63b2afe4bb67704ac23e commit 0a1572b8bb880a63d50a63b2afe4bb67704ac23e Author: Matheus Castanho Date: Tue Jun 7 10:27:26 2022 -0300 powerpc: Fix VSX register number on __strncpy_power9 [BZ #29197] __strncpy_power9 initializes VR 18 with zeroes to be used throughout the code, including when zero-padding the destination string. However, the v18 reference was mistakenly being used for stxv and stxvl, which take a VSX vector as operand. The code ended up using the uninitialized VSR 18 register by mistake. Both occurrences have been changed to use the proper VSX number for VR 18 (i.e. VSR 50). Tested on powerpc, powerpc64 and powerpc64le. Signed-off-by: Kewen Lin (cherry picked from commit 0218463dd8265ed937622f88ac68c7d984fe0cfc) Diff: --- sysdeps/powerpc/powerpc64/le/power9/strncpy.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sysdeps/powerpc/powerpc64/le/power9/strncpy.S b/sysdeps/powerpc/powerpc64/le/power9/strncpy.S index ae23161316..deb94671cc 100644 --- a/sysdeps/powerpc/powerpc64/le/power9/strncpy.S +++ b/sysdeps/powerpc/powerpc64/le/power9/strncpy.S @@ -352,7 +352,7 @@ L(zero_padding_loop): cmpldi cr6,r5,16 /* Check if length was reached. */ ble cr6,L(zero_padding_end) - stxv v18,0(r11) + stxv 32+v18,0(r11) addi r11,r11,16 addi r5,r5,-16 @@ -360,7 +360,7 @@ L(zero_padding_loop): L(zero_padding_end): sldi r10,r5,56 /* stxvl wants size in top 8 bits */ - stxvl v18,r11,r10 /* Partial store */ + stxvl 32+v18,r11,r10 /* Partial store */ blr .align 4