From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 7844) id 07A3A3839C62; Tue, 7 Jun 2022 20:45:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 07A3A3839C62 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Noah Goldstein To: glibc-cvs@sourceware.org Subject: [glibc] x86: ZERO_UPPER_VEC_REGISTERS_RETURN_XTEST expect no transactions X-Act-Checkin: glibc X-Git-Author: Noah Goldstein X-Git-Refname: refs/heads/master X-Git-Oldrev: 56da3fe1dd075285fa8186d44b3c28e68c687e62 X-Git-Newrev: c28db9cb29a7d6cf3ce08fd8445e6b7dea03f35b Message-Id: <20220607204507.07A3A3839C62@sourceware.org> Date: Tue, 7 Jun 2022 20:45:07 +0000 (GMT) X-BeenThere: glibc-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Glibc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jun 2022 20:45:07 -0000 https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=c28db9cb29a7d6cf3ce08fd8445e6b7dea03f35b commit c28db9cb29a7d6cf3ce08fd8445e6b7dea03f35b Author: Noah Goldstein Date: Fri Jun 3 18:52:37 2022 -0500 x86: ZERO_UPPER_VEC_REGISTERS_RETURN_XTEST expect no transactions Give fall-through path to `vzeroupper` and taken-path to `vzeroall`. Generally even on machines with RTM the expectation is the string-library functions will not be called in transactions. Reviewed-by: H.J. Lu Diff: --- sysdeps/x86_64/sysdep.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sysdeps/x86_64/sysdep.h b/sysdeps/x86_64/sysdep.h index 4f512d5566..7f5defa4ec 100644 --- a/sysdeps/x86_64/sysdep.h +++ b/sysdeps/x86_64/sysdep.h @@ -99,11 +99,11 @@ lose: \ to avoid RTM abort triggered by VZEROUPPER inside transactionally. */ #define ZERO_UPPER_VEC_REGISTERS_RETURN_XTEST \ xtest; \ - jz 1f; \ - vzeroall; \ + jnz 1f; \ + vzeroupper; \ ret; \ 1: \ - vzeroupper; \ + vzeroall; \ ret /* Can be used to replace vzeroupper that is not directly before a