public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Adhemerval Zanella <azanella@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc/azanella/clang] resolv: Handle -Wsometimes-uninitialized on getaddrinfo
Date: Thu,  9 Jun 2022 13:18:07 +0000 (GMT)	[thread overview]
Message-ID: <20220609131807.6680F38344E9@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=b4e460061bbfcdd5195f93f1ecf41818c8502134

commit b4e460061bbfcdd5195f93f1ecf41818c8502134
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Tue Mar 22 16:01:34 2022 -0300

    resolv: Handle -Wsometimes-uninitialized on getaddrinfo

Diff:
---
 sysdeps/posix/getaddrinfo.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/sysdeps/posix/getaddrinfo.c b/sysdeps/posix/getaddrinfo.c
index db4cd2f12f..9fd7b9a63d 100644
--- a/sysdeps/posix/getaddrinfo.c
+++ b/sysdeps/posix/getaddrinfo.c
@@ -1867,6 +1867,10 @@ add_prefixlist (struct prefixlist **listp, size_t *lenp, bool *nullbitsp,
   if (cp != NULL)
     *cp++ = '\0';
   *pos = cp;
+  /* clang warns that endp is used uninitialized whenever '||' condition
+     is true, however it will be evaluated after strtoul call.  */
+  DIAG_PUSH_NEEDS_COMMENT_CLANG;
+  DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wsometimes-uninitialized");
   if (inet_pton (AF_INET6, val1, &prefix)
       && (cp == NULL
 	  || (bits = strtoul (cp, &endp, 10)) != ULONG_MAX
@@ -1890,6 +1894,7 @@ add_prefixlist (struct prefixlist **listp, size_t *lenp, bool *nullbitsp,
       ++*lenp;
       *nullbitsp |= bits == 0;
     }
+  DIAG_POP_NEEDS_COMMENT_CLANG;
   return true;
 }
 
@@ -2028,6 +2033,11 @@ gaiconf_init (void)
 	      if (inet_pton (AF_INET6, val1, &prefix))
 		{
 		  bits = 128;
+		  /* clang warns that endp is used uninitialized whenever '||'
+		     condition is true, however it will be evaluated after
+		     strtoul call.  */
+		  DIAG_PUSH_NEEDS_COMMENT_CLANG;
+		  DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wsometimes-uninitialized");
 		  if (IN6_IS_ADDR_V4MAPPED (&prefix)
 		      && (cp == NULL
 			  || (bits = strtoul (cp, &endp, 10)) != ULONG_MAX
@@ -2049,6 +2059,7 @@ gaiconf_init (void)
 			  goto no_file;
 			}
 		    }
+		  DIAG_POP_NEEDS_COMMENT_CLANG;
 		}
 	      else if (inet_pton (AF_INET, val1, &prefix.s6_addr32[3])
 		       && (cp == NULL


             reply	other threads:[~2022-06-09 13:18 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-09 13:18 Adhemerval Zanella [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-01-29 17:54 Adhemerval Zanella
2023-12-21 18:51 Adhemerval Zanella
2023-09-28 17:49 Adhemerval Zanella
2023-08-30 12:34 Adhemerval Zanella
2023-02-09 19:46 Adhemerval Zanella
2022-10-28 17:39 Adhemerval Zanella
2022-10-04 12:57 Adhemerval Zanella
2022-06-09 21:21 Adhemerval Zanella
2022-06-03 14:07 Adhemerval Zanella
2022-05-13 14:21 Adhemerval Zanella
2022-05-12 19:35 Adhemerval Zanella
2022-05-10 18:25 Adhemerval Zanella
2022-04-29 14:05 Adhemerval Zanella
2022-04-04 12:55 Adhemerval Zanella
2022-03-31 19:08 Adhemerval Zanella
2022-03-29 20:31 Adhemerval Zanella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220609131807.6680F38344E9@sourceware.org \
    --to=azanella@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).