From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1895) id 4D8C2383D830; Fri, 10 Jun 2022 12:38:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4D8C2383D830 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Wilco Dijkstra To: glibc-cvs@sourceware.org Subject: [glibc] libio: Avoid RMW of flags2 outside lock (BZ #27842) X-Act-Checkin: glibc X-Git-Author: Wilco Dijkstra X-Git-Refname: refs/heads/master X-Git-Oldrev: cffb9414c55b2e169ed8af1cefd1e3f2ea97e750 X-Git-Newrev: f107b7b30d815f191181617e2c14f21e6af4ddcf Message-Id: <20220610123822.4D8C2383D830@sourceware.org> Date: Fri, 10 Jun 2022 12:38:22 +0000 (GMT) X-BeenThere: glibc-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Glibc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jun 2022 12:38:22 -0000 https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=f107b7b30d815f191181617e2c14f21e6af4ddcf commit f107b7b30d815f191181617e2c14f21e6af4ddcf Author: Wilco Dijkstra Date: Fri Jun 10 13:33:26 2022 +0100 libio: Avoid RMW of flags2 outside lock (BZ #27842) Remove an unconditional RMW on flags2 in flockfile - we don't need to change _IO_FLAGS2_NEED_LOCK since it isn't used in flockfile or funlockfile. This fixes BZ #27842. Reviewed-by: Adhemerval Zanella Diff: --- stdio-common/flockfile.c | 1 - 1 file changed, 1 deletion(-) diff --git a/stdio-common/flockfile.c b/stdio-common/flockfile.c index a5decb450f..49f72c69ab 100644 --- a/stdio-common/flockfile.c +++ b/stdio-common/flockfile.c @@ -22,7 +22,6 @@ void __flockfile (FILE *stream) { - stream->_flags2 |= _IO_FLAGS2_NEED_LOCK; _IO_lock_lock (*stream->_lock); } weak_alias (__flockfile, flockfile);