public inbox for glibc-cvs@sourceware.org help / color / mirror / Atom feed
From: DJ Delorie <dj@sourceware.org> To: glibc-cvs@sourceware.org Subject: [glibc/release/2.34/master] nss: add assert to DB_LOOKUP_FCT (BZ #28752) Date: Tue, 14 Jun 2022 02:58:53 +0000 (GMT) [thread overview] Message-ID: <20220614025853.30115386DC55@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=368c5c3e001a37571b61ab342f2b654c3d23643d commit 368c5c3e001a37571b61ab342f2b654c3d23643d Author: Sam James <sam@gentoo.org> Date: Sun Jun 5 04:57:09 2022 +0100 nss: add assert to DB_LOOKUP_FCT (BZ #28752) It's interesting if we have a null action list, so an assert is worthwhile. Suggested-by: DJ Delorie <dj@redhat.com> Signed-off-by: Sam James <sam@gentoo.org> Reviewed-by: DJ Delorie <dj@redhat.com> (cherry picked from commit 3fdf0a205b622e40fa7e3c4ed1e4ed4d5c6c5380) Diff: --- nss/XXX-lookup.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/nss/XXX-lookup.c b/nss/XXX-lookup.c index dbc87868dd..343fd9869b 100644 --- a/nss/XXX-lookup.c +++ b/nss/XXX-lookup.c @@ -16,6 +16,7 @@ License along with the GNU C Library; if not, see <https://www.gnu.org/licenses/>. */ +#include <assert.h> #include "nsswitch.h" /*******************************************************************\ @@ -55,6 +56,10 @@ DB_LOOKUP_FCT (nss_action_list *ni, const char *fct_name, const char *fct2_name, *ni = DATABASE_NAME_SYMBOL; + /* We want to know about it if we've somehow got a NULL action list; + in the past, we had bad state if seccomp interfered with setup. */ + assert(*ni != NULL); + return __nss_lookup (ni, fct_name, fct2_name, fctp); } libc_hidden_def (DB_LOOKUP_FCT)
reply other threads:[~2022-06-14 2:58 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220614025853.30115386DC55@sourceware.org \ --to=dj@sourceware.org \ --cc=glibc-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).