From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 7814) id 585AF3858407; Thu, 16 Jun 2022 02:21:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 585AF3858407 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Fangrui Song To: glibc-cvs@sourceware.org Subject: [glibc] aarch64: Handle fewer relocations for RTLD_BOOTSTRAP X-Act-Checkin: glibc X-Git-Author: Fangrui Song X-Git-Refname: refs/heads/master X-Git-Oldrev: 57919813e732dff2c6cfd1c95056cbc265058bc2 X-Git-Newrev: e89913d0aa36597e5824baec870dfcec525fab1a Message-Id: <20220616022156.585AF3858407@sourceware.org> Date: Thu, 16 Jun 2022 02:21:56 +0000 (GMT) X-BeenThere: glibc-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Glibc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jun 2022 02:21:56 -0000 https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=e89913d0aa36597e5824baec870dfcec525fab1a commit e89913d0aa36597e5824baec870dfcec525fab1a Author: Fangrui Song Date: Wed Jun 15 19:21:53 2022 -0700 aarch64: Handle fewer relocations for RTLD_BOOTSTRAP The RTLD_BOOTSTRAP branch is used to relocate ld.so itself. It only needs to handle RELATIVE, GLOB_DAT, and JUMP_SLOT. TLSDESC/TLS_DTPMOD/TLS_DTPREL handling can be removed. Remove `case AARCH64_R(RELATIVE)` as well as elf_machine_rela has checked it. Tested on aarch64-linux-gnu. Diff: --- sysdeps/aarch64/dl-machine.h | 33 +++++++++++++++------------------ 1 file changed, 15 insertions(+), 18 deletions(-) diff --git a/sysdeps/aarch64/dl-machine.h b/sysdeps/aarch64/dl-machine.h index 292abe5152..ae8b14425a 100644 --- a/sysdeps/aarch64/dl-machine.h +++ b/sysdeps/aarch64/dl-machine.h @@ -178,7 +178,9 @@ elf_machine_rela (struct link_map *map, struct r_scope_elem *scope[], return; else { +# ifndef RTLD_BOOTSTRAP const ElfW(Sym) *const refsym = sym; +# endif struct link_map *sym_map = RESOLVE_MAP (map, scope, &sym, version, r_type); ElfW(Addr) value = SYMBOL_ADDRESS (sym_map, sym, true); @@ -191,6 +193,18 @@ elf_machine_rela (struct link_map *map, struct r_scope_elem *scope[], switch (r_type) { + case AARCH64_R(GLOB_DAT): + case AARCH64_R(JUMP_SLOT): + *reloc_addr = value + reloc->r_addend; + break; + +# ifndef RTLD_BOOTSTRAP + case AARCH64_R(ABS32): +# ifdef __LP64__ + case AARCH64_R(ABS64): +# endif + *reloc_addr = value + reloc->r_addend; + break; case AARCH64_R(COPY): if (sym == NULL) break; @@ -210,30 +224,17 @@ elf_machine_rela (struct link_map *map, struct r_scope_elem *scope[], ? sym->st_size : refsym->st_size); break; - case AARCH64_R(RELATIVE): - case AARCH64_R(GLOB_DAT): - case AARCH64_R(JUMP_SLOT): - case AARCH64_R(ABS32): -#ifdef __LP64__ - case AARCH64_R(ABS64): -#endif - *reloc_addr = value + reloc->r_addend; - break; - case AARCH64_R(TLSDESC): { struct tlsdesc volatile *td = (struct tlsdesc volatile *)reloc_addr; -#ifndef RTLD_BOOTSTRAP if (! sym) { td->arg = (void*)reloc->r_addend; td->entry = _dl_tlsdesc_undefweak; } else -#endif { -#ifndef RTLD_BOOTSTRAP # ifndef SHARED CHECK_STATIC_TLS (map, sym_map); # else @@ -245,7 +246,6 @@ elf_machine_rela (struct link_map *map, struct r_scope_elem *scope[], } else # endif -#endif { td->arg = (void*)(sym->st_value + sym_map->l_tls_offset + reloc->r_addend); @@ -256,14 +256,10 @@ elf_machine_rela (struct link_map *map, struct r_scope_elem *scope[], } case AARCH64_R(TLS_DTPMOD): -#ifdef RTLD_BOOTSTRAP - *reloc_addr = 1; -#else if (sym_map != NULL) { *reloc_addr = sym_map->l_tls_modid; } -#endif break; case AARCH64_R(TLS_DTPREL): @@ -286,6 +282,7 @@ elf_machine_rela (struct link_map *map, struct r_scope_elem *scope[], value = elf_ifunc_invoke (value); *reloc_addr = value; break; +# endif /* !RTLD_BOOTSTRAP */ default: _dl_reloc_bad_type (map, r_type, 0);