public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: H.J. Lu <hjl@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc] x86-64: Don't mark symbols as hidden in strcmp-XXX.S
Date: Fri,  8 Jul 2022 00:06:27 +0000 (GMT)	[thread overview]
Message-ID: <20220708000627.5A417385043A@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=eedf7886ed81750d0f81735034682cf0a4d8bee1

commit eedf7886ed81750d0f81735034682cf0a4d8bee1
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Thu Jul 7 16:20:50 2022 -0700

    x86-64: Don't mark symbols as hidden in strcmp-XXX.S
    
    Don't mark symbols as hidden in strcmp-avx2.S, strcmp-evex.S and
    strcmp-sse42.S since they are marked as hidden in the IFUNC selectors.

Diff:
---
 sysdeps/x86_64/multiarch/strcmp-avx2.S  | 1 -
 sysdeps/x86_64/multiarch/strcmp-evex.S  | 1 -
 sysdeps/x86_64/multiarch/strcmp-sse42.S | 1 -
 3 files changed, 3 deletions(-)

diff --git a/sysdeps/x86_64/multiarch/strcmp-avx2.S b/sysdeps/x86_64/multiarch/strcmp-avx2.S
index 8da09bd86d..516cde1145 100644
--- a/sysdeps/x86_64/multiarch/strcmp-avx2.S
+++ b/sysdeps/x86_64/multiarch/strcmp-avx2.S
@@ -184,7 +184,6 @@
 	.align	16
 	.type	STRCMP, @function
 	.globl	STRCMP
-	.hidden	STRCMP
 
 # ifndef GLABEL
 #  define GLABEL(...)	__VA_ARGS__
diff --git a/sysdeps/x86_64/multiarch/strcmp-evex.S b/sysdeps/x86_64/multiarch/strcmp-evex.S
index 2a5b3ce037..e97d51bb26 100644
--- a/sysdeps/x86_64/multiarch/strcmp-evex.S
+++ b/sysdeps/x86_64/multiarch/strcmp-evex.S
@@ -214,7 +214,6 @@
 	.align	16
 	.type	STRCMP, @function
 	.globl	STRCMP
-	.hidden	STRCMP
 
 # ifdef USE_AS_STRCASECMP_L
 ENTRY (STRCASECMP)
diff --git a/sysdeps/x86_64/multiarch/strcmp-sse42.S b/sysdeps/x86_64/multiarch/strcmp-sse42.S
index a9178ad25c..60313c647a 100644
--- a/sysdeps/x86_64/multiarch/strcmp-sse42.S
+++ b/sysdeps/x86_64/multiarch/strcmp-sse42.S
@@ -77,7 +77,6 @@
 	.align	16
 	.type	STRCMP_SSE42, @function
 	.globl	STRCMP_SSE42
-	.hidden	STRCMP_SSE42
 #ifdef USE_AS_STRCASECMP_L
 ENTRY (GLABEL(__strcasecmp))
 	movq	__libc_tsd_LOCALE@gottpoff(%rip),%rax


                 reply	other threads:[~2022-07-08  0:06 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220708000627.5A417385043A@sourceware.org \
    --to=hjl@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).