public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Fangrui Song <maskray@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc] i386: Remove -Wa,-mtune=i686
Date: Tue, 12 Jul 2022 18:14:34 +0000 (GMT)	[thread overview]
Message-ID: <20220712181434.3F2683858C50@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=c5bec9d491c5d066dd238ccafcdec78cd4592e8e

commit c5bec9d491c5d066dd238ccafcdec78cd4592e8e
Author: Fangrui Song <maskray@google.com>
Date:   Tue Jul 12 11:14:32 2022 -0700

    i386: Remove -Wa,-mtune=i686
    
    gas -mtune= may change NOP generating patterns but -mtune=i686 has no
    difference from the default by inspecting .o and .os files.
    
    Note: Clang doesn't support -Wa,-mtune=i686.

Diff:
---
 sysdeps/i386/i686/Makefile | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/sysdeps/i386/i686/Makefile b/sysdeps/i386/i686/Makefile
index 311042787b..6b5fc8a59c 100644
--- a/sysdeps/i386/i686/Makefile
+++ b/sysdeps/i386/i686/Makefile
@@ -1,12 +1,2 @@
 # So that we can test __m128's alignment
 stack-align-test-flags += -msse
-
-CFLAGS-.o += -Wa,-mtune=i686
-CFLAGS-.os += -Wa,-mtune=i686
-CFLAGS-.op += -Wa,-mtune=i686
-CFLAGS-.oS += -Wa,-mtune=i686
-
-ASFLAGS-.o += -Wa,-mtune=i686
-ASFLAGS-.os += -Wa,-mtune=i686
-ASFLAGS-.op += -Wa,-mtune=i686
-ASFLAGS-.oS += -Wa,-mtune=i686


                 reply	other threads:[~2022-07-12 18:14 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220712181434.3F2683858C50@sourceware.org \
    --to=maskray@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).