public inbox for glibc-cvs@sourceware.org help / color / mirror / Atom feed
From: Stefan Liebler <stli@sourceware.org> To: glibc-cvs@sourceware.org Subject: [glibc] S390: Define SINGLE_THREAD_BY_GLOBAL only on s390x Date: Thu, 14 Jul 2022 11:39:56 +0000 (GMT) [thread overview] Message-ID: <20220714113956.7565B3857363@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=779aa039fc4151bdc0d79ef2e141604863856a60 commit 779aa039fc4151bdc0d79ef2e141604863856a60 Author: Stefan Liebler <stli@linux.ibm.com> Date: Thu Jul 14 13:39:09 2022 +0200 S390: Define SINGLE_THREAD_BY_GLOBAL only on s390x Starting with commit e070501d12b47e88c1ff8c313f887976fb578938 "Replace __libc_multiple_threads with __libc_single_threaded" the testcases nptl/tst-cancel-self and nptl/tst-cancel-self-cancelstate are failing. This is fixed by only defining SINGLE_THREAD_BY_GLOBAL on s390x, but not on s390. Starting with commit 09c76a74099826f4c6e1c4c431d7659f78112862 "Linux: Consolidate {RTLD_}SINGLE_THREAD_P definition", SINGLE_THREAD_BY_GLOBAL was defined in sysdeps/unix/sysv/linux/s390/s390-64/sysdep.h. Lateron the commit 9a973da617772eff1f351989f8995f4305a2e63c "s390: Consolidate Linux syscall definition" consolidates the sysdep.h files from s390-32/s390-64 subdirectories. Unfortunately the macro is now always defined instead of only on s390-64. As information: TLS_MULTIPLE_THREADS_IN_TCB is also only defined for s390. See: sysdeps/s390/nptl/tls.h Diff: --- sysdeps/unix/sysv/linux/s390/{ => s390-64}/single-thread.h | 0 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/sysdeps/unix/sysv/linux/s390/single-thread.h b/sysdeps/unix/sysv/linux/s390/s390-64/single-thread.h similarity index 100% rename from sysdeps/unix/sysv/linux/s390/single-thread.h rename to sysdeps/unix/sysv/linux/s390/s390-64/single-thread.h
reply other threads:[~2022-07-14 11:39 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220714113956.7565B3857363@sourceware.org \ --to=stli@sourceware.org \ --cc=glibc-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).