public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc/release/2.35/master] x86: ZERO_UPPER_VEC_REGISTERS_RETURN_XTEST expect no transactions
@ 2022-07-18 20:58 Sunil Pandey
  0 siblings, 0 replies; only message in thread
From: Sunil Pandey @ 2022-07-18 20:58 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=e74385736c659915b26c4c85a32e2ebb4806ffa4

commit e74385736c659915b26c4c85a32e2ebb4806ffa4
Author: Noah Goldstein <goldstein.w.n@gmail.com>
Date:   Fri Jun 3 18:52:37 2022 -0500

    x86: ZERO_UPPER_VEC_REGISTERS_RETURN_XTEST expect no transactions
    
    Give fall-through path to `vzeroupper` and taken-path to `vzeroall`.
    
    Generally even on machines with RTM the expectation is the
    string-library functions will not be called in transactions.
    Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
    
    (cherry picked from commit c28db9cb29a7d6cf3ce08fd8445e6b7dea03f35b)

Diff:
---
 sysdeps/x86_64/sysdep.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/sysdeps/x86_64/sysdep.h b/sysdeps/x86_64/sysdep.h
index 4f512d5566..7f5defa4ec 100644
--- a/sysdeps/x86_64/sysdep.h
+++ b/sysdeps/x86_64/sysdep.h
@@ -99,11 +99,11 @@ lose:									      \
    to avoid RTM abort triggered by VZEROUPPER inside transactionally.  */
 #define ZERO_UPPER_VEC_REGISTERS_RETURN_XTEST \
 	xtest;							\
-	jz	1f;						\
-	vzeroall;						\
+	jnz	1f;						\
+	vzeroupper;						\
 	ret;							\
 1:								\
-	vzeroupper;						\
+	vzeroall;						\
 	ret
 
 /* Can be used to replace vzeroupper that is not directly before a


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-07-18 20:58 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-18 20:58 [glibc/release/2.35/master] x86: ZERO_UPPER_VEC_REGISTERS_RETURN_XTEST expect no transactions Sunil Pandey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).