From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <skpgkp2@sourceware.org>
Received: by sourceware.org (Postfix, from userid 7852)
 id 883513852779; Mon, 18 Jul 2022 20:59:13 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 883513852779
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: Sunil Pandey <skpgkp2@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc/release/2.35/master] x86: Add missing IS_IN (libc) check to
 strncmp-sse4_2.S
X-Act-Checkin: glibc
X-Git-Author: Noah Goldstein <goldstein.w.n@gmail.com>
X-Git-Refname: refs/heads/release/2.35/master
X-Git-Oldrev: fdf699edeafe240fde6d0ff223c63185c8446bfc
X-Git-Newrev: c4050b25527c80a989b5f3349b7ea2bf5acf3fd2
Message-Id: <20220718205913.883513852779@sourceware.org>
Date: Mon, 18 Jul 2022 20:59:13 +0000 (GMT)
X-BeenThere: glibc-cvs@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Glibc-cvs mailing list <glibc-cvs.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/glibc-cvs>,
 <mailto:glibc-cvs-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/glibc-cvs/>
List-Help: <mailto:glibc-cvs-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/glibc-cvs>,
 <mailto:glibc-cvs-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Jul 2022 20:59:13 -0000

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=c4050b25527c80a989b5f3349b7ea2bf5acf3fd2

commit c4050b25527c80a989b5f3349b7ea2bf5acf3fd2
Author: Noah Goldstein <goldstein.w.n@gmail.com>
Date:   Wed Jun 29 18:56:18 2022 -0700

    x86: Add missing IS_IN (libc) check to strncmp-sse4_2.S
    
    Was missing to for the multiarch build rtld-strncmp-sse4_2.os was
    being built and exporting symbols:
    
    build/glibc/string/rtld-strncmp-sse4_2.os:
    0000000000000000 T __strncmp_sse42
    
    Introduced in:
    
    commit 11ffcacb64a939c10cfc713746b8ec88837f5c4a
    Author: H.J. Lu <hjl.tools@gmail.com>
    Date:   Wed Jun 21 12:10:50 2017 -0700
    
        x86-64: Implement strcmp family IFUNC selectors in C
    
    (cherry picked from commit 96ac447d915ea5ecef3f9168cc13f4e731349a3b)

Diff:
---
 sysdeps/x86_64/multiarch/strncmp-sse4_2.S | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/sysdeps/x86_64/multiarch/strncmp-sse4_2.S b/sysdeps/x86_64/multiarch/strncmp-sse4_2.S
index 9773e5fc09..310a6dbe77 100644
--- a/sysdeps/x86_64/multiarch/strncmp-sse4_2.S
+++ b/sysdeps/x86_64/multiarch/strncmp-sse4_2.S
@@ -16,6 +16,8 @@
    License along with the GNU C Library; if not, see
    <https://www.gnu.org/licenses/>.  */
 
-#define STRCMP_SSE42 __strncmp_sse42
-#define USE_AS_STRNCMP
-#include "strcmp-sse42.S"
+#if IS_IN (libc)
+# define STRCMP_SSE42 __strncmp_sse42
+# define USE_AS_STRNCMP
+# include "strcmp-sse42.S"
+#endif