public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Adhemerval Zanella <azanella@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc] struct stat is not posix conformant on microblaze with __USE_FILE_OFFSET64
Date: Mon, 25 Jul 2022 14:07:20 +0000 (GMT)	[thread overview]
Message-ID: <20220725140720.294D5383B781@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=794c27446fd735526d9d782478edd1141b10e3ab

commit 794c27446fd735526d9d782478edd1141b10e3ab
Author: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Date:   Mon Jul 25 11:25:15 2022 +0200

    struct stat is not posix conformant on microblaze with __USE_FILE_OFFSET64
    
    Commit a06b40cdf5ba0d2ab4f9b4c77d21e45ff284fac7 updated stat.h to use
    __USE_XOPEN2K8 instead of __USE_MISC to add the st_atim, st_mtim and
    st_ctim members to struct stat. However, for microblaze, there are two
    definitions of struct stat, depending on the __USE_FILE_OFFSET64 macro.
    The second one was not updated.
    
    Change __USE_MISC to __USE_XOPEN2K8 in the __USE_FILE_OFFSET64 version
    of struct stat for microblaze.

Diff:
---
 sysdeps/unix/sysv/linux/microblaze/bits/struct_stat.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sysdeps/unix/sysv/linux/microblaze/bits/struct_stat.h b/sysdeps/unix/sysv/linux/microblaze/bits/struct_stat.h
index a2787e8834..850697f4fa 100644
--- a/sysdeps/unix/sysv/linux/microblaze/bits/struct_stat.h
+++ b/sysdeps/unix/sysv/linux/microblaze/bits/struct_stat.h
@@ -89,7 +89,7 @@ struct stat
         __blksize_t             st_blksize; /* Optimal block size for I/O.  */
         int                     __pad3;
         __blkcnt64_t            st_blocks;  /* Number 512-byte blocks allocated.  */
-# ifdef __USE_MISC
+# ifdef __USE_XOPEN2K8
         /* Nanosecond resolution timestamps are stored in a format
          * equivalent to 'struct timespec'. This is the type used
          * whenever possible but the Unix namespace rules do not allow the


                 reply	other threads:[~2022-07-25 14:07 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220725140720.294D5383B781@sourceware.org \
    --to=azanella@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).