public inbox for glibc-cvs@sourceware.org help / color / mirror / Atom feed
From: Florian Weimer <fw@sourceware.org> To: glibc-cvs@sourceware.org Subject: [glibc] nptl: Remove uses of assert_perror Date: Wed, 3 Aug 2022 09:45:46 +0000 (GMT) [thread overview] Message-ID: <20220803094546.8971C3858011@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=68e036f27f31c3378201702e182246504fb00f87 commit 68e036f27f31c3378201702e182246504fb00f87 Author: Florian Weimer <fweimer@redhat.com> Date: Wed Aug 3 11:41:53 2022 +0200 nptl: Remove uses of assert_perror __pthread_sigmask cannot actually fail with valid pointer arguments (it would need a really broken seccomp filter), and we do not check for errors elsewhere. Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org> Diff: --- sysdeps/nptl/gai_misc.h | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/sysdeps/nptl/gai_misc.h b/sysdeps/nptl/gai_misc.h index c09350c2ed..4196eac6e6 100644 --- a/sysdeps/nptl/gai_misc.h +++ b/sysdeps/nptl/gai_misc.h @@ -81,9 +81,7 @@ __gai_start_notify_thread (void) { sigset_t ss; sigemptyset (&ss); - int sigerr __attribute__ ((unused)); - sigerr = __pthread_sigmask (SIG_SETMASK, &ss, NULL); - assert_perror (sigerr); + (void) __pthread_sigmask (SIG_SETMASK, &ss, NULL); } extern inline int @@ -106,15 +104,12 @@ __gai_create_helper_thread (pthread_t *threadp, void *(*tf) (void *), sigset_t ss; sigset_t oss; sigfillset (&ss); - int sigerr __attribute__ ((unused)); - sigerr = __pthread_sigmask (SIG_SETMASK, &ss, &oss); - assert_perror (sigerr); + (void) __pthread_sigmask (SIG_SETMASK, &ss, &oss); int ret = __pthread_create (threadp, &attr, tf, arg); /* Restore the signal mask. */ - sigerr = __pthread_sigmask (SIG_SETMASK, &oss, NULL); - assert_perror (sigerr); + (void) __pthread_sigmask (SIG_SETMASK, &oss, NULL); (void) __pthread_attr_destroy (&attr); return ret;
reply other threads:[~2022-08-03 9:45 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220803094546.8971C3858011@sourceware.org \ --to=fw@sourceware.org \ --cc=glibc-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).