From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2178) id 8971C3858011; Wed, 3 Aug 2022 09:45:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8971C3858011 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Florian Weimer To: glibc-cvs@sourceware.org Subject: [glibc] nptl: Remove uses of assert_perror X-Act-Checkin: glibc X-Git-Author: Florian Weimer X-Git-Refname: refs/heads/master X-Git-Oldrev: cca9684f2d7a74fc0b28bfb1859955e0e28d7b4b X-Git-Newrev: 68e036f27f31c3378201702e182246504fb00f87 Message-Id: <20220803094546.8971C3858011@sourceware.org> Date: Wed, 3 Aug 2022 09:45:46 +0000 (GMT) X-BeenThere: glibc-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Glibc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Aug 2022 09:45:46 -0000 https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=68e036f27f31c3378201702e182246504fb00f87 commit 68e036f27f31c3378201702e182246504fb00f87 Author: Florian Weimer Date: Wed Aug 3 11:41:53 2022 +0200 nptl: Remove uses of assert_perror __pthread_sigmask cannot actually fail with valid pointer arguments (it would need a really broken seccomp filter), and we do not check for errors elsewhere. Reviewed-by: Adhemerval Zanella Diff: --- sysdeps/nptl/gai_misc.h | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/sysdeps/nptl/gai_misc.h b/sysdeps/nptl/gai_misc.h index c09350c2ed..4196eac6e6 100644 --- a/sysdeps/nptl/gai_misc.h +++ b/sysdeps/nptl/gai_misc.h @@ -81,9 +81,7 @@ __gai_start_notify_thread (void) { sigset_t ss; sigemptyset (&ss); - int sigerr __attribute__ ((unused)); - sigerr = __pthread_sigmask (SIG_SETMASK, &ss, NULL); - assert_perror (sigerr); + (void) __pthread_sigmask (SIG_SETMASK, &ss, NULL); } extern inline int @@ -106,15 +104,12 @@ __gai_create_helper_thread (pthread_t *threadp, void *(*tf) (void *), sigset_t ss; sigset_t oss; sigfillset (&ss); - int sigerr __attribute__ ((unused)); - sigerr = __pthread_sigmask (SIG_SETMASK, &ss, &oss); - assert_perror (sigerr); + (void) __pthread_sigmask (SIG_SETMASK, &ss, &oss); int ret = __pthread_create (threadp, &attr, tf, arg); /* Restore the signal mask. */ - sigerr = __pthread_sigmask (SIG_SETMASK, &oss, NULL); - assert_perror (sigerr); + (void) __pthread_sigmask (SIG_SETMASK, &oss, NULL); (void) __pthread_attr_destroy (&attr); return ret;