public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Florian Weimer <fw@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc] malloc: Correct the documentation of the top_pad default
Date: Thu,  4 Aug 2022 15:21:21 +0000 (GMT)	[thread overview]
Message-ID: <20220804152121.963F63858407@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=6c93af6b458031ebba5484bdc0029ad92720d51d

commit 6c93af6b458031ebba5484bdc0029ad92720d51d
Author: Florian Weimer <fweimer@redhat.com>
Date:   Thu Aug 4 10:24:47 2022 +0200

    malloc: Correct the documentation of the top_pad default
    
    DEFAULT_TOP_PAD is defined as 131072 in
    sysdeps/generic/malloc-machine.h.

Diff:
---
 elf/dl-tunables.list           | 1 +
 elf/tst-rtld-list-tunables.exp | 2 +-
 manual/tunables.texi           | 2 +-
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/elf/dl-tunables.list b/elf/dl-tunables.list
index e6a56b3070..e925590c36 100644
--- a/elf/dl-tunables.list
+++ b/elf/dl-tunables.list
@@ -42,6 +42,7 @@ glibc {
       type: SIZE_T
       env_alias: MALLOC_TOP_PAD_
       security_level: SXID_IGNORE
+      default: 131072
     }
     perturb {
       type: INT_32
diff --git a/elf/tst-rtld-list-tunables.exp b/elf/tst-rtld-list-tunables.exp
index cdfdb56a94..2233ea9c7c 100644
--- a/elf/tst-rtld-list-tunables.exp
+++ b/elf/tst-rtld-list-tunables.exp
@@ -9,7 +9,7 @@ glibc.malloc.perturb: 0 (min: 0, max: 255)
 glibc.malloc.tcache_count: 0x0 (min: 0x0, max: 0x[f]+)
 glibc.malloc.tcache_max: 0x0 (min: 0x0, max: 0x[f]+)
 glibc.malloc.tcache_unsorted_limit: 0x0 (min: 0x0, max: 0x[f]+)
-glibc.malloc.top_pad: 0x0 (min: 0x0, max: 0x[f]+)
+glibc.malloc.top_pad: 0x20000 (min: 0x0, max: 0x[f]+)
 glibc.malloc.trim_threshold: 0x0 (min: 0x0, max: 0x[f]+)
 glibc.rtld.dynamic_sort: 2 (min: 1, max: 2)
 glibc.rtld.nns: 0x4 (min: 0x1, max: 0x10)
diff --git a/manual/tunables.texi b/manual/tunables.texi
index 83cdcdac6d..ffd50a3fe2 100644
--- a/manual/tunables.texi
+++ b/manual/tunables.texi
@@ -143,7 +143,7 @@ number of bytes to retain when shrinking any of the arenas.  This provides the
 necessary hysteresis in heap size such that excessive amounts of system calls
 can be avoided.
 
-The default value of this tunable is @samp{0}.
+The default value of this tunable is @samp{131072} (128 KB).
 @end deftp
 
 @deftp Tunable glibc.malloc.perturb


                 reply	other threads:[~2022-08-04 15:21 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220804152121.963F63858407@sourceware.org \
    --to=fw@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).