public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] i386: Replace movzx with movzbl
@ 2022-08-04 21:06 Fangrui Song
  0 siblings, 0 replies; only message in thread
From: Fangrui Song @ 2022-08-04 21:06 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=525ca33a61edd733e8ad8c0456f8f811adc2ccb9

commit 525ca33a61edd733e8ad8c0456f8f811adc2ccb9
Author: Fangrui Song <maskray@google.com>
Date:   Thu Aug 4 14:06:50 2022 -0700

    i386: Replace movzx with movzbl
    
    Similar to 6720d36b6623c5e48c070d86acf61198b33e144e for x86-64.
    
    Clang cannot assemble movzx in the AT&T dialect mode.  Change movzx to
    movzbl, which follows the AT&T dialect and is used elsewhere in the
    file.

Diff:
---
 sysdeps/i386/i686/multiarch/strcmp-ssse3.S | 36 +++++++++++++++---------------
 1 file changed, 18 insertions(+), 18 deletions(-)

diff --git a/sysdeps/i386/i686/multiarch/strcmp-ssse3.S b/sysdeps/i386/i686/multiarch/strcmp-ssse3.S
index ac5096f68d..3435691f23 100644
--- a/sysdeps/i386/i686/multiarch/strcmp-ssse3.S
+++ b/sysdeps/i386/i686/multiarch/strcmp-ssse3.S
@@ -2141,8 +2141,8 @@ L(less16bytes):
 	jbe	L(eq)
 #endif
 
-	movzx	7(%eax), %ecx
-	movzx	7(%edx), %eax
+	movzbl	7(%eax), %ecx
+	movzbl	7(%edx), %eax
 #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
 # ifdef PIC
 	movl	_nl_C_LC_CTYPE_tolower@GOTOFF+128*4(%ebx,%ecx,4), %ecx
@@ -2161,8 +2161,8 @@ L(Byte0):
 	cmp	$0, REM
 	jbe	L(eq)
 #endif
-	movzx	(%eax), %ecx
-	movzx	(%edx), %eax
+	movzbl	(%eax), %ecx
+	movzbl	(%edx), %eax
 
 #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
 # ifdef PIC
@@ -2182,8 +2182,8 @@ L(Byte1):
 	cmp	$1, REM
 	jbe	L(eq)
 #endif
-	movzx	1(%eax), %ecx
-	movzx	1(%edx), %eax
+	movzbl	1(%eax), %ecx
+	movzbl	1(%edx), %eax
 
 #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
 # ifdef PIC
@@ -2203,8 +2203,8 @@ L(Byte2):
 	cmp	$2, REM
 	jbe	L(eq)
 #endif
-	movzx	2(%eax), %ecx
-	movzx	2(%edx), %eax
+	movzbl	2(%eax), %ecx
+	movzbl	2(%edx), %eax
 
 #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
 # ifdef PIC
@@ -2224,8 +2224,8 @@ L(Byte3):
 	cmp	$3, REM
 	jbe	L(eq)
 #endif
-	movzx	3(%eax), %ecx
-	movzx	3(%edx), %eax
+	movzbl	3(%eax), %ecx
+	movzbl	3(%edx), %eax
 
 #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
 # ifdef PIC
@@ -2245,8 +2245,8 @@ L(Byte4):
 	cmp	$4, REM
 	jbe	L(eq)
 #endif
-	movzx	4(%eax), %ecx
-	movzx	4(%edx), %eax
+	movzbl	4(%eax), %ecx
+	movzbl	4(%edx), %eax
 
 #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
 # ifdef PIC
@@ -2266,8 +2266,8 @@ L(Byte5):
 	cmp	$5, REM
 	jbe	L(eq)
 #endif
-	movzx	5(%eax), %ecx
-	movzx	5(%edx), %eax
+	movzbl	5(%eax), %ecx
+	movzbl	5(%edx), %eax
 
 #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
 # ifdef PIC
@@ -2287,8 +2287,8 @@ L(Byte6):
 	cmp	$6, REM
 	jbe	L(eq)
 #endif
-	movzx	6(%eax), %ecx
-	movzx	6(%edx), %eax
+	movzbl	6(%eax), %ecx
+	movzbl	6(%edx), %eax
 
 #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
 # ifdef PIC
@@ -2337,8 +2337,8 @@ L(2next_8_bytes):
 	cmp	$7, REM
 	jbe	L(eq)
 #endif
-	movzx	7(%eax), %ecx
-	movzx	7(%edx), %eax
+	movzbl	7(%eax), %ecx
+	movzbl	7(%edx), %eax
 
 #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L
 # ifdef PIC


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-08-04 21:06 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-04 21:06 [glibc] i386: Replace movzx with movzbl Fangrui Song

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).