public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Szabolcs Nagy <nsz@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc/arm/morello/main] cheri: fix pointer tagging in tsearch
Date: Fri,  5 Aug 2022 19:35:20 +0000 (GMT)	[thread overview]
Message-ID: <20220805193520.1CCB93857363@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=68822420a6da19adf0030ddc836c6968b071b467

commit 68822420a6da19adf0030ddc836c6968b071b467
Author: Szabolcs Nagy <szabolcs.nagy@arm.com>
Date:   Mon Jul 12 11:11:05 2021 +0100

    cheri: fix pointer tagging in tsearch
    
    USE_MALLOC_LOW_BIT should work for capabilities too, but we need to
    ensure that pointer provenance is right: the red/black flag is
    computed as uintptr_t, but with uintptr_t | uintptr_t it's not clear
    which side provides the provenance.
    
    So use unsigned int type for the flag (which is the type used in case
    of !USE_MALLOC_LOW_BIT anyway), then unsigned int | uintptr_t works.
    
    The type of RED is corrected too to match unsigned int.

Diff:
---
 misc/tsearch.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/misc/tsearch.c b/misc/tsearch.c
index 852cadf7b9..1787cf4991 100644
--- a/misc/tsearch.c
+++ b/misc/tsearch.c
@@ -131,15 +131,15 @@ typedef struct node_t
   uintptr_t right_node;
 } *node;
 
-#define RED(N) (node)((N)->left_node & ((uintptr_t) 0x1))
+#define RED(N) (unsigned int)((N)->left_node & ((uintptr_t) 0x1))
 #define SETRED(N) (N)->left_node |= ((uintptr_t) 0x1)
 #define SETBLACK(N) (N)->left_node &= ~((uintptr_t) 0x1)
-#define SETNODEPTR(NP,P) (*NP) = (node)((((uintptr_t)(*NP)) \
+#define SETNODEPTR(NP,P) (*NP) = (node)((unsigned int)(((uintptr_t)(*NP)) \
 					 & (uintptr_t) 0x1) | (uintptr_t)(P))
 #define LEFT(N) (node)((N)->left_node & ~((uintptr_t) 0x1))
 #define LEFTPTR(N) (node *)(&(N)->left_node)
-#define SETLEFT(N,L) (N)->left_node = (((N)->left_node & (uintptr_t) 0x1) \
-				       | (uintptr_t)(L))
+#define SETLEFT(N,L) (N)->left_node = ((unsigned int)((N)->left_node \
+					 & (uintptr_t) 0x1) | (uintptr_t)(L))
 #define RIGHT(N) (node)((N)->right_node)
 #define RIGHTPTR(N) (node *)(&(N)->right_node)
 #define SETRIGHT(N,R) (N)->right_node = (uintptr_t)(R)


             reply	other threads:[~2022-08-05 19:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-05 19:35 Szabolcs Nagy [this message]
2022-10-26 15:18 Szabolcs Nagy
2022-10-27 13:56 Szabolcs Nagy
2022-11-23 14:46 Szabolcs Nagy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220805193520.1CCB93857363@sourceware.org \
    --to=nsz@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).