public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc/arm/morello/main] cheri: malloc: Disable pointer protection
@ 2022-08-05 19:35 Szabolcs Nagy
  0 siblings, 0 replies; 4+ messages in thread
From: Szabolcs Nagy @ 2022-08-05 19:35 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=b3d26f52f7084c1f008b3c746c01db4f122f7879

commit b3d26f52f7084c1f008b3c746c01db4f122f7879
Author: Szabolcs Nagy <szabolcs.nagy@arm.com>
Date:   Wed Jul 7 14:21:40 2021 +0100

    cheri: malloc: Disable pointer protection
    
    Such arithmetic invalidates capabilities so this security measure does
    not work for CHERI.
    
    Note: the architecture makes it hard to corrupt pointers in malloc
    metadata, but not impossible: current allocation bounds include the
    metadata and capabilities are not revoked after free. These issues can
    be fixed by a capability aware malloc.

Diff:
---
 malloc/malloc.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/malloc/malloc.c b/malloc/malloc.c
index bd3c76ed31..062ca0dc0a 100644
--- a/malloc/malloc.c
+++ b/malloc/malloc.c
@@ -341,8 +341,12 @@ Fatal glibc error: malloc assertion failure in %s: %s\n",
    It assumes a minimum page size of 4096 bytes (12 bits).  Systems with
    larger pages provide less entropy, although the pointer mangling
    still works.  */
+#ifdef __CHERI_PURE_CAPABILITY__
+#define PROTECT_PTR(pos, ptr) (ptr)
+#else
 #define PROTECT_PTR(pos, ptr) \
   ((__typeof (ptr)) ((((size_t) pos) >> 12) ^ ((size_t) ptr)))
+#endif
 #define REVEAL_PTR(ptr)  PROTECT_PTR (&ptr, ptr)
 
 /*


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [glibc/arm/morello/main] cheri: malloc: Disable pointer protection
@ 2022-11-23 14:46 Szabolcs Nagy
  0 siblings, 0 replies; 4+ messages in thread
From: Szabolcs Nagy @ 2022-11-23 14:46 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=0f2a4c9573e3c1f2e593f450cc27e6f4e6a84ddc

commit 0f2a4c9573e3c1f2e593f450cc27e6f4e6a84ddc
Author: Szabolcs Nagy <szabolcs.nagy@arm.com>
Date:   Wed Jul 7 14:21:40 2021 +0100

    cheri: malloc: Disable pointer protection
    
    Such arithmetic invalidates capabilities so this security measure does
    not work for CHERI.
    
    Note: the architecture makes it hard to corrupt pointers in malloc
    metadata, but not impossible: current allocation bounds include the
    metadata and capabilities are not revoked after free. These issues can
    be fixed by a capability aware malloc.

Diff:
---
 malloc/malloc.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/malloc/malloc.c b/malloc/malloc.c
index bd3c76ed31..062ca0dc0a 100644
--- a/malloc/malloc.c
+++ b/malloc/malloc.c
@@ -341,8 +341,12 @@ Fatal glibc error: malloc assertion failure in %s: %s\n",
    It assumes a minimum page size of 4096 bytes (12 bits).  Systems with
    larger pages provide less entropy, although the pointer mangling
    still works.  */
+#ifdef __CHERI_PURE_CAPABILITY__
+#define PROTECT_PTR(pos, ptr) (ptr)
+#else
 #define PROTECT_PTR(pos, ptr) \
   ((__typeof (ptr)) ((((size_t) pos) >> 12) ^ ((size_t) ptr)))
+#endif
 #define REVEAL_PTR(ptr)  PROTECT_PTR (&ptr, ptr)
 
 /*

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [glibc/arm/morello/main] cheri: malloc: Disable pointer protection
@ 2022-10-27 13:56 Szabolcs Nagy
  0 siblings, 0 replies; 4+ messages in thread
From: Szabolcs Nagy @ 2022-10-27 13:56 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=883d0c4a228ea9ae5c988bf87e99451bb80b1266

commit 883d0c4a228ea9ae5c988bf87e99451bb80b1266
Author: Szabolcs Nagy <szabolcs.nagy@arm.com>
Date:   Wed Jul 7 14:21:40 2021 +0100

    cheri: malloc: Disable pointer protection
    
    Such arithmetic invalidates capabilities so this security measure does
    not work for CHERI.
    
    Note: the architecture makes it hard to corrupt pointers in malloc
    metadata, but not impossible: current allocation bounds include the
    metadata and capabilities are not revoked after free. These issues can
    be fixed by a capability aware malloc.

Diff:
---
 malloc/malloc.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/malloc/malloc.c b/malloc/malloc.c
index bd3c76ed31..062ca0dc0a 100644
--- a/malloc/malloc.c
+++ b/malloc/malloc.c
@@ -341,8 +341,12 @@ Fatal glibc error: malloc assertion failure in %s: %s\n",
    It assumes a minimum page size of 4096 bytes (12 bits).  Systems with
    larger pages provide less entropy, although the pointer mangling
    still works.  */
+#ifdef __CHERI_PURE_CAPABILITY__
+#define PROTECT_PTR(pos, ptr) (ptr)
+#else
 #define PROTECT_PTR(pos, ptr) \
   ((__typeof (ptr)) ((((size_t) pos) >> 12) ^ ((size_t) ptr)))
+#endif
 #define REVEAL_PTR(ptr)  PROTECT_PTR (&ptr, ptr)
 
 /*

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [glibc/arm/morello/main] cheri: malloc: Disable pointer protection
@ 2022-10-26 15:18 Szabolcs Nagy
  0 siblings, 0 replies; 4+ messages in thread
From: Szabolcs Nagy @ 2022-10-26 15:18 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=5440678ee1801698f97c52e227aaeff7a84e4516

commit 5440678ee1801698f97c52e227aaeff7a84e4516
Author: Szabolcs Nagy <szabolcs.nagy@arm.com>
Date:   Wed Jul 7 14:21:40 2021 +0100

    cheri: malloc: Disable pointer protection
    
    Such arithmetic invalidates capabilities so this security measure does
    not work for CHERI.
    
    Note: the architecture makes it hard to corrupt pointers in malloc
    metadata, but not impossible: current allocation bounds include the
    metadata and capabilities are not revoked after free. These issues can
    be fixed by a capability aware malloc.

Diff:
---
 malloc/malloc.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/malloc/malloc.c b/malloc/malloc.c
index bd3c76ed31..062ca0dc0a 100644
--- a/malloc/malloc.c
+++ b/malloc/malloc.c
@@ -341,8 +341,12 @@ Fatal glibc error: malloc assertion failure in %s: %s\n",
    It assumes a minimum page size of 4096 bytes (12 bits).  Systems with
    larger pages provide less entropy, although the pointer mangling
    still works.  */
+#ifdef __CHERI_PURE_CAPABILITY__
+#define PROTECT_PTR(pos, ptr) (ptr)
+#else
 #define PROTECT_PTR(pos, ptr) \
   ((__typeof (ptr)) ((((size_t) pos) >> 12) ^ ((size_t) ptr)))
+#endif
 #define REVEAL_PTR(ptr)  PROTECT_PTR (&ptr, ptr)
 
 /*

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-11-23 14:46 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-05 19:35 [glibc/arm/morello/main] cheri: malloc: Disable pointer protection Szabolcs Nagy
2022-10-26 15:18 Szabolcs Nagy
2022-10-27 13:56 Szabolcs Nagy
2022-11-23 14:46 Szabolcs Nagy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).