public inbox for
help / color / mirror / Atom feed
* [glibc/arm/morello/main] TODO(morello): cheri: fix posix timers
@ 2022-08-05 19:37 Szabolcs Nagy
  0 siblings, 0 replies; only message in thread
From: Szabolcs Nagy @ 2022-08-05 19:37 UTC (permalink / raw)
  To: glibc-cvs;h=bb648757f04e595b029be6ceaa6e2db66876c8cb

commit bb648757f04e595b029be6ceaa6e2db66876c8cb
Author: Szabolcs Nagy <>
Date:   Tue Apr 19 15:18:56 2022 +0100

    TODO(morello): cheri: fix posix timers
    We need to distinguish timerids that are small integers returned by
    the kernel and timerids that are pointers to struct timer. The existing
    pointer tagging does not work for CHERI because of the pointer shift.
    Simply use the top bit without shift to tag pointers. This still relies
    on the top byte ignore of aarch64 (the top byte does not affect the
    capability representation) and that pointers are not tagged for other
    reasons (like HWASAN).
    TODO: this is morello specific and does not work for generic cheri.

 sysdeps/unix/sysv/linux/kernel-posix-timers.h | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/sysdeps/unix/sysv/linux/kernel-posix-timers.h b/sysdeps/unix/sysv/linux/kernel-posix-timers.h
index 82ce92f2ae..371e328258 100644
--- a/sysdeps/unix/sysv/linux/kernel-posix-timers.h
+++ b/sysdeps/unix/sysv/linux/kernel-posix-timers.h
@@ -79,6 +79,25 @@ kernel_timer_to_timerid (kernel_timer_t ktimerid)
   return (timer_t) ((intptr_t) ktimerid);
+static inline timer_t
+timer_to_timerid (struct timer *ptr)
+  return (timer_t) ((uintptr_t) ptr | ~(-1UL/2));
+static inline bool
+timer_is_sigev_thread (timer_t timerid)
+  return ((uintptr_t) timerid & ~(-1UL/2)) != 0;
+static inline struct timer *
+timerid_to_timer (timer_t timerid)
+  return (struct timer *)((uintptr_t) timerid & (-1UL/2));
 static inline timer_t
 timer_to_timerid (struct timer *ptr)
@@ -96,6 +115,7 @@ timerid_to_timer (timer_t timerid)
   return (struct timer *)((uintptr_t) timerid << 1);
 static inline kernel_timer_t
 timerid_to_kernel_timer (timer_t timerid)

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-08-05 19:37 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-05 19:37 [glibc/arm/morello/main] TODO(morello): cheri: fix posix timers Szabolcs Nagy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).