From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2178) id DABE23858CDA; Tue, 6 Sep 2022 06:19:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DABE23858CDA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1662445140; bh=+9LrbcSgssI3bdeN4fNuyLfLoX83oWEPhZ25F74u8JQ=; h=From:To:Subject:Date:From; b=j0wKXK4FENcJHoyp5xtflvVv/Q6dN4gi27Y4LC6aVZI400LHVOHccFWG3oL8XmYpF dmv2rzPn7jzYfXaUC7Qj0N7deVv+3RdknunB5URFu+Q/WDufm1F1sv4DWb5iF6yYs8 kdXkOP4+/4EdhbyHxg+oqY30hDgaI6chfGgQJgHc= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Florian Weimer To: glibc-cvs@sourceware.org Subject: [glibc] scripts/dso-ordering-test.py: Generate program run-time dependencies X-Act-Checkin: glibc X-Git-Author: Florian Weimer X-Git-Refname: refs/heads/master X-Git-Oldrev: 2fc7320668ee843f9d1e5a2ec6c6fdbf00c735a3 X-Git-Newrev: 183d99737298bb3200f0610fdcd1c7549c8ed560 Message-Id: <20220906061900.DABE23858CDA@sourceware.org> Date: Tue, 6 Sep 2022 06:19:00 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=183d99737298bb3200f0610fdcd1c7549c8ed560 commit 183d99737298bb3200f0610fdcd1c7549c8ed560 Author: Florian Weimer Date: Tue Sep 6 07:38:10 2022 +0200 scripts/dso-ordering-test.py: Generate program run-time dependencies The main program needs to depend on all shared objects, even objects that have link-time dependencies among shared objects. Filtering out shared objects that already have an link-time dependencies is not necessary here; make will do this automatically. Reviewed-by: Adhemerval Zanella Diff: --- scripts/dso-ordering-test.py | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/scripts/dso-ordering-test.py b/scripts/dso-ordering-test.py index 2dd6bfda18..b87cf2f809 100644 --- a/scripts/dso-ordering-test.py +++ b/scripts/dso-ordering-test.py @@ -707,13 +707,12 @@ def process_testcase(t): "\t$(compile.c) $(OUTPUT_OPTION)\n") makefile.write (rule) - not_depended_objs = find_objs_not_depended_on(test_descr) - if not_depended_objs: - depstr = "" - for dep in not_depended_objs: - depstr += (" $(objpfx)" + test_subdir + "/" - + test_name + "-" + dep + ".so") - makefile.write("$(objpfx)%s.out:%s\n" % (base_test_name, depstr)) + # Ensure that all shared objects are built before running the + # test, whether there link-time dependencies or not. + depobjs = ["$(objpfx){}/{}-{}.so".format(test_subdir, test_name, dep) + for dep in test_descr.objs] + makefile.write("$(objpfx){}.out: {}\n".format( + base_test_name, " ".join(depobjs))) # Add main executable to test-srcs makefile.write("test-srcs += %s/%s\n" % (test_subdir, test_name))