From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2178) id C0AB03850863; Tue, 6 Sep 2022 16:32:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C0AB03850863 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1662481941; bh=ndi/CA5ZGFD9csqHopNBgadc2Dh/6FmWLcA8Mde6e9U=; h=From:To:Subject:Date:From; b=fEnXoKSAuy8YdVe/oMVPJCXRyv8mbGeOYrR5XwamJeawUhToMyeQmX9tYIkYn9yUt M/m6gnR29QxrRa06CoQJevvyWaBAOdO40IRPL9wVzIO8Wd+5VsLthwAJjOtwf7PTQJ HSjnPQYSKtFUSupUJUC1Z9K5RIWobVm4nQZH5kAA= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Florian Weimer To: glibc-cvs@sourceware.org Subject: [glibc/release/2.35/master] nscd: Fix netlink cache invalidation if epoll is used [BZ #29415] X-Act-Checkin: glibc X-Git-Author: Fabian Vogt X-Git-Refname: refs/heads/release/2.35/master X-Git-Oldrev: 9e960717e10a35d165212ea54d91bd89efd8d4fb X-Git-Newrev: f8ad66a4cab14ed294bf50e7a9eddb73da6cf307 Message-Id: <20220906163221.C0AB03850863@sourceware.org> Date: Tue, 6 Sep 2022 16:32:21 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=f8ad66a4cab14ed294bf50e7a9eddb73da6cf307 commit f8ad66a4cab14ed294bf50e7a9eddb73da6cf307 Author: Fabian Vogt Date: Wed Jul 27 11:44:07 2022 +0200 nscd: Fix netlink cache invalidation if epoll is used [BZ #29415] Processes cache network interface information such as whether IPv4 or IPv6 are enabled. This is only checked again if the "netlink timestamp" provided by nscd changed, which is triggered by netlink socket activity. However, in the epoll handler for the netlink socket, it was missed to assign the new timestamp to the nscd database. The handler for plain poll did that properly, copy that over. This bug caused that e.g. processes which started before network configuration got unusuable addresses from getaddrinfo, like IPv6 only even though only IPv4 is available: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/1041 It's a bit hard to reproduce, so I verified this by checking the timestamp on calls to __check_pf manually. Without this patch it's stuck at 1, now it's increasing on network changes as expected. Signed-off-by: Fabian Vogt (cherry picked from commit 02ca25fef2785974011e9c5beecc99b900b69fd7) Diff: --- NEWS | 1 + nscd/connections.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 1a16fc30a9..cabd3f0b5e 100644 --- a/NEWS +++ b/NEWS @@ -46,6 +46,7 @@ The following bugs are resolved with this release: [29214] nptl: pthread_setcanceltype fails to set type [29225] network: Mistyped define statement in socket/sys/socket.h in line 184 + [29415] nscd: Fix netlink cache invalidation if epoll is used [29446] _dlopen now ignores dl_caller argument in static mode [29490] alpha: New __brk_call implementation is broken [29528] elf: Call __libc_early_init for reused namespaces diff --git a/nscd/connections.c b/nscd/connections.c index 61d1674eb4..531d2e83df 100644 --- a/nscd/connections.c +++ b/nscd/connections.c @@ -2284,7 +2284,8 @@ main_loop_epoll (int efd) sizeof (buf))) != -1) ; - __bump_nl_timestamp (); + dbs[hstdb].head->extra_data[NSCD_HST_IDX_CONF_TIMESTAMP] + = __bump_nl_timestamp (); } # endif else