public inbox for glibc-cvs@sourceware.org help / color / mirror / Atom feed
From: Wilco Dijkstra <wilco@sourceware.org> To: glibc-cvs@sourceware.org Subject: [glibc] malloc: Use C11 atomics rather than atomic_exchange_and_add Date: Tue, 6 Sep 2022 16:53:51 +0000 (GMT) [thread overview] Message-ID: <20220906165351.974C3385354A@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=89d40cacd0aed35e2546513ce01924b879523e46 commit 89d40cacd0aed35e2546513ce01924b879523e46 Author: Wilco Dijkstra <wdijkstr@arm.com> Date: Tue Sep 6 16:49:01 2022 +0100 malloc: Use C11 atomics rather than atomic_exchange_and_add Replace a few counters using atomic_exchange_and_add with atomic_fetch_add_relaxed. Reviewed-by: Florian Weimer <fweimer@redhat.com> Diff: --- malloc/malloc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/malloc/malloc.c b/malloc/malloc.c index 29fa71b3b2..ecec901b14 100644 --- a/malloc/malloc.c +++ b/malloc/malloc.c @@ -2460,11 +2460,11 @@ sysmalloc_mmap (INTERNAL_SIZE_T nb, size_t pagesize, int extra_flags, mstate av) } /* update statistics */ - int new = atomic_exchange_and_add (&mp_.n_mmaps, 1) + 1; + int new = atomic_fetch_add_relaxed (&mp_.n_mmaps, 1) + 1; atomic_max (&mp_.max_n_mmaps, new); unsigned long sum; - sum = atomic_exchange_and_add (&mp_.mmapped_mem, size) + size; + sum = atomic_fetch_add_relaxed (&mp_.mmapped_mem, size) + size; atomic_max (&mp_.max_mmapped_mem, sum); check_chunk (av, p); @@ -3084,7 +3084,7 @@ mremap_chunk (mchunkptr p, size_t new_size) set_head (p, (new_size - offset) | IS_MMAPPED); INTERNAL_SIZE_T new; - new = atomic_exchange_and_add (&mp_.mmapped_mem, new_size - size - offset) + new = atomic_fetch_add_relaxed (&mp_.mmapped_mem, new_size - size - offset) + new_size - size - offset; atomic_max (&mp_.max_mmapped_mem, new); return p;
reply other threads:[~2022-09-06 16:53 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220906165351.974C3385354A@sourceware.org \ --to=wilco@sourceware.org \ --cc=glibc-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).