public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Adhemerval Zanella <azanella@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc] linux: Use same type for MMAP2_PAGE_UNIT
Date: Tue, 20 Sep 2022 16:29:20 +0000 (GMT) [thread overview]
Message-ID: <20220920162920.07CC438582A8@sourceware.org> (raw)
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=85a322874404d1a13e9d628b8bc44120cabf7e12
commit 85a322874404d1a13e9d628b8bc44120cabf7e12
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date: Thu Mar 10 08:07:37 2022 -0300
linux: Use same type for MMAP2_PAGE_UNIT
It avoid a possible compiler warning where right size of operator
is converted from a negative value to unsigned.
Reviewed-by: Florian Weimer <fweimer@redhat.com>
Diff:
---
sysdeps/unix/sysv/linux/arc/mmap_internal.h | 2 +-
sysdeps/unix/sysv/linux/ia64/mmap_internal.h | 2 +-
sysdeps/unix/sysv/linux/m68k/mmap_internal.h | 2 +-
sysdeps/unix/sysv/linux/mmap_internal.h | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/sysdeps/unix/sysv/linux/arc/mmap_internal.h b/sysdeps/unix/sysv/linux/arc/mmap_internal.h
index d8bbcab0a1..59e8260b5c 100644
--- a/sysdeps/unix/sysv/linux/arc/mmap_internal.h
+++ b/sysdeps/unix/sysv/linux/arc/mmap_internal.h
@@ -20,7 +20,7 @@
#define MMAP_ARC_INTERNAL_H
/* 8K is default but determine the shift dynamically with getpagesize. */
-#define MMAP2_PAGE_UNIT -1
+#define MMAP2_PAGE_UNIT -1ULL
#include_next <mmap_internal.h>
diff --git a/sysdeps/unix/sysv/linux/ia64/mmap_internal.h b/sysdeps/unix/sysv/linux/ia64/mmap_internal.h
index 0c0a0ced99..465d589281 100644
--- a/sysdeps/unix/sysv/linux/ia64/mmap_internal.h
+++ b/sysdeps/unix/sysv/linux/ia64/mmap_internal.h
@@ -22,7 +22,7 @@
/* Linux allows PAGE_SHIFT in range of [12-16] and expect
mmap2 offset to be provided in based on the configured pagesize.
Determine the shift dynamically with getpagesize. */
-#define MMAP2_PAGE_UNIT -1
+#define MMAP2_PAGE_UNIT -1ULL
#include_next <mmap_internal.h>
diff --git a/sysdeps/unix/sysv/linux/m68k/mmap_internal.h b/sysdeps/unix/sysv/linux/m68k/mmap_internal.h
index 8e6f1ed84c..9330edfc05 100644
--- a/sysdeps/unix/sysv/linux/m68k/mmap_internal.h
+++ b/sysdeps/unix/sysv/linux/m68k/mmap_internal.h
@@ -22,7 +22,7 @@
/* ColdFire and Sun 3 kernels have PAGE_SHIFT set to 13 and expect
mmap2 offset to be provided in 8K pages. Determine the shift
dynamically with getpagesize. */
-#define MMAP2_PAGE_UNIT -1
+#define MMAP2_PAGE_UNIT -1ULL
#include_next <mmap_internal.h>
diff --git a/sysdeps/unix/sysv/linux/mmap_internal.h b/sysdeps/unix/sysv/linux/mmap_internal.h
index aebf97d064..2d118b0d8a 100644
--- a/sysdeps/unix/sysv/linux/mmap_internal.h
+++ b/sysdeps/unix/sysv/linux/mmap_internal.h
@@ -28,7 +28,7 @@
# define MMAP2_PAGE_UNIT 4096ULL
#endif
-#if MMAP2_PAGE_UNIT == -1
+#if MMAP2_PAGE_UNIT == -1ULL
static uint64_t page_unit;
# define MMAP_CHECK_PAGE_UNIT() \
if (page_unit == 0) \
reply other threads:[~2022-09-20 16:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220920162920.07CC438582A8@sourceware.org \
--to=azanella@sourceware.org \
--cc=glibc-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).