public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc/users/skpgkp2/2.33/master] Move assignment out of the CAS condition
@ 2022-09-28 19:11 Sunil Pandey
  0 siblings, 0 replies; 3+ messages in thread
From: Sunil Pandey @ 2022-09-28 19:11 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=520639f146eecc5baee7b0a9fc8fc3f416bcbd68

commit 520639f146eecc5baee7b0a9fc8fc3f416bcbd68
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Fri Nov 12 11:47:42 2021 -0800

    Move assignment out of the CAS condition
    
    Update
    
    commit 49302b8fdf9103b6fc0a398678668a22fa19574c
    Author: H.J. Lu <hjl.tools@gmail.com>
    Date:   Thu Nov 11 06:54:01 2021 -0800
    
        Avoid extra load with CAS in __pthread_mutex_clocklock_common [BZ #28537]
    
        Replace boolean CAS with value CAS to avoid the extra load.
    
    and
    
    commit 0b82747dc48d5bf0871bdc6da8cb6eec1256355f
    Author: H.J. Lu <hjl.tools@gmail.com>
    Date:   Thu Nov 11 06:31:51 2021 -0800
    
        Avoid extra load with CAS in __pthread_mutex_lock_full [BZ #28537]
    
        Replace boolean CAS with value CAS to avoid the extra load.
    
    by moving assignment out of the CAS condition.
    
    (cherry picked from commit 120ac6d238825452e8024e2f627da33b2508dfd3)

Diff:
---
 nptl/pthread_mutex_lock.c      | 7 +++----
 nptl/pthread_mutex_timedlock.c | 7 +++----
 2 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/nptl/pthread_mutex_lock.c b/nptl/pthread_mutex_lock.c
index ac8a472c08..2895926953 100644
--- a/nptl/pthread_mutex_lock.c
+++ b/nptl/pthread_mutex_lock.c
@@ -296,10 +296,9 @@ __pthread_mutex_lock_full (pthread_mutex_t *mutex)
 	     meantime.  */
 	  if ((oldval & FUTEX_WAITERS) == 0)
 	    {
-	      int val;
-	      if ((val = atomic_compare_and_exchange_val_acq
-		   (&mutex->__data.__lock, oldval | FUTEX_WAITERS,
-		    oldval)) != oldval)
+	      int val = atomic_compare_and_exchange_val_acq
+		(&mutex->__data.__lock, oldval | FUTEX_WAITERS, oldval);
+	      if (val != oldval)
 		{
 		  oldval = val;
 		  continue;
diff --git a/nptl/pthread_mutex_timedlock.c b/nptl/pthread_mutex_timedlock.c
index 541ec18938..22174f74c9 100644
--- a/nptl/pthread_mutex_timedlock.c
+++ b/nptl/pthread_mutex_timedlock.c
@@ -247,10 +247,9 @@ __pthread_mutex_clocklock_common (pthread_mutex_t *mutex,
 	     meantime.  */
 	  if ((oldval & FUTEX_WAITERS) == 0)
 	    {
-	      int val;
-	      if ((val = atomic_compare_and_exchange_val_acq
-		   (&mutex->__data.__lock, oldval | FUTEX_WAITERS,
-		    oldval)) != oldval)
+	      int val = atomic_compare_and_exchange_val_acq
+		(&mutex->__data.__lock, oldval | FUTEX_WAITERS, oldval);
+	      if (val != oldval)
 		{
 		  oldval = val;
 		  continue;

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [glibc/users/skpgkp2/2.33/master] Move assignment out of the CAS condition
@ 2022-09-29 18:41 Sunil Pandey
  0 siblings, 0 replies; 3+ messages in thread
From: Sunil Pandey @ 2022-09-29 18:41 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=60b8295333a076ff853c1093c502c7bf5197ab2e

commit 60b8295333a076ff853c1093c502c7bf5197ab2e
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Fri Nov 12 11:47:42 2021 -0800

    Move assignment out of the CAS condition
    
    Update
    
    commit 49302b8fdf9103b6fc0a398678668a22fa19574c
    Author: H.J. Lu <hjl.tools@gmail.com>
    Date:   Thu Nov 11 06:54:01 2021 -0800
    
        Avoid extra load with CAS in __pthread_mutex_clocklock_common [BZ #28537]
    
        Replace boolean CAS with value CAS to avoid the extra load.
    
    and
    
    commit 0b82747dc48d5bf0871bdc6da8cb6eec1256355f
    Author: H.J. Lu <hjl.tools@gmail.com>
    Date:   Thu Nov 11 06:31:51 2021 -0800
    
        Avoid extra load with CAS in __pthread_mutex_lock_full [BZ #28537]
    
        Replace boolean CAS with value CAS to avoid the extra load.
    
    by moving assignment out of the CAS condition.
    
    (cherry picked from commit 120ac6d238825452e8024e2f627da33b2508dfd3)

Diff:
---
 nptl/pthread_mutex_lock.c      | 7 +++----
 nptl/pthread_mutex_timedlock.c | 7 +++----
 2 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/nptl/pthread_mutex_lock.c b/nptl/pthread_mutex_lock.c
index ac8a472c08..2895926953 100644
--- a/nptl/pthread_mutex_lock.c
+++ b/nptl/pthread_mutex_lock.c
@@ -296,10 +296,9 @@ __pthread_mutex_lock_full (pthread_mutex_t *mutex)
 	     meantime.  */
 	  if ((oldval & FUTEX_WAITERS) == 0)
 	    {
-	      int val;
-	      if ((val = atomic_compare_and_exchange_val_acq
-		   (&mutex->__data.__lock, oldval | FUTEX_WAITERS,
-		    oldval)) != oldval)
+	      int val = atomic_compare_and_exchange_val_acq
+		(&mutex->__data.__lock, oldval | FUTEX_WAITERS, oldval);
+	      if (val != oldval)
 		{
 		  oldval = val;
 		  continue;
diff --git a/nptl/pthread_mutex_timedlock.c b/nptl/pthread_mutex_timedlock.c
index 541ec18938..22174f74c9 100644
--- a/nptl/pthread_mutex_timedlock.c
+++ b/nptl/pthread_mutex_timedlock.c
@@ -247,10 +247,9 @@ __pthread_mutex_clocklock_common (pthread_mutex_t *mutex,
 	     meantime.  */
 	  if ((oldval & FUTEX_WAITERS) == 0)
 	    {
-	      int val;
-	      if ((val = atomic_compare_and_exchange_val_acq
-		   (&mutex->__data.__lock, oldval | FUTEX_WAITERS,
-		    oldval)) != oldval)
+	      int val = atomic_compare_and_exchange_val_acq
+		(&mutex->__data.__lock, oldval | FUTEX_WAITERS, oldval);
+	      if (val != oldval)
 		{
 		  oldval = val;
 		  continue;

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [glibc/users/skpgkp2/2.33/master] Move assignment out of the CAS condition
@ 2022-09-28 21:45 Sunil Pandey
  0 siblings, 0 replies; 3+ messages in thread
From: Sunil Pandey @ 2022-09-28 21:45 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=c0370912f15c2ed07c0524530c9dee320701e317

commit c0370912f15c2ed07c0524530c9dee320701e317
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Fri Nov 12 11:47:42 2021 -0800

    Move assignment out of the CAS condition
    
    Update
    
    commit 49302b8fdf9103b6fc0a398678668a22fa19574c
    Author: H.J. Lu <hjl.tools@gmail.com>
    Date:   Thu Nov 11 06:54:01 2021 -0800
    
        Avoid extra load with CAS in __pthread_mutex_clocklock_common [BZ #28537]
    
        Replace boolean CAS with value CAS to avoid the extra load.
    
    and
    
    commit 0b82747dc48d5bf0871bdc6da8cb6eec1256355f
    Author: H.J. Lu <hjl.tools@gmail.com>
    Date:   Thu Nov 11 06:31:51 2021 -0800
    
        Avoid extra load with CAS in __pthread_mutex_lock_full [BZ #28537]
    
        Replace boolean CAS with value CAS to avoid the extra load.
    
    by moving assignment out of the CAS condition.
    
    (cherry picked from commit 120ac6d238825452e8024e2f627da33b2508dfd3)

Diff:
---
 nptl/pthread_mutex_lock.c      | 7 +++----
 nptl/pthread_mutex_timedlock.c | 7 +++----
 2 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/nptl/pthread_mutex_lock.c b/nptl/pthread_mutex_lock.c
index ac8a472c08..2895926953 100644
--- a/nptl/pthread_mutex_lock.c
+++ b/nptl/pthread_mutex_lock.c
@@ -296,10 +296,9 @@ __pthread_mutex_lock_full (pthread_mutex_t *mutex)
 	     meantime.  */
 	  if ((oldval & FUTEX_WAITERS) == 0)
 	    {
-	      int val;
-	      if ((val = atomic_compare_and_exchange_val_acq
-		   (&mutex->__data.__lock, oldval | FUTEX_WAITERS,
-		    oldval)) != oldval)
+	      int val = atomic_compare_and_exchange_val_acq
+		(&mutex->__data.__lock, oldval | FUTEX_WAITERS, oldval);
+	      if (val != oldval)
 		{
 		  oldval = val;
 		  continue;
diff --git a/nptl/pthread_mutex_timedlock.c b/nptl/pthread_mutex_timedlock.c
index 541ec18938..22174f74c9 100644
--- a/nptl/pthread_mutex_timedlock.c
+++ b/nptl/pthread_mutex_timedlock.c
@@ -247,10 +247,9 @@ __pthread_mutex_clocklock_common (pthread_mutex_t *mutex,
 	     meantime.  */
 	  if ((oldval & FUTEX_WAITERS) == 0)
 	    {
-	      int val;
-	      if ((val = atomic_compare_and_exchange_val_acq
-		   (&mutex->__data.__lock, oldval | FUTEX_WAITERS,
-		    oldval)) != oldval)
+	      int val = atomic_compare_and_exchange_val_acq
+		(&mutex->__data.__lock, oldval | FUTEX_WAITERS, oldval);
+	      if (val != oldval)
 		{
 		  oldval = val;
 		  continue;

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-09-29 18:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-28 19:11 [glibc/users/skpgkp2/2.33/master] Move assignment out of the CAS condition Sunil Pandey
2022-09-28 21:45 Sunil Pandey
2022-09-29 18:41 Sunil Pandey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).