public inbox for
help / color / mirror / Atom feed
From: Sunil Pandey <>
Subject: [glibc/users/skpgkp2/2.33/master] sysdeps: Add 'get_fast_jitter' interace in fast-jitter.h
Date: Thu, 29 Sep 2022 18:41:49 +0000 (GMT)	[thread overview]
Message-ID: <> (raw);h=870d564e7cd7335734273c8f0fc01a49f5feccc5

commit 870d564e7cd7335734273c8f0fc01a49f5feccc5
Author: Noah Goldstein <>
Date:   Wed Apr 27 15:13:02 2022 -0500

    sysdeps: Add 'get_fast_jitter' interace in fast-jitter.h
    'get_fast_jitter' is meant to be used purely for performance
    purposes. In all cases it's used it should be acceptable to get no
    randomness (see default case). An example use case is in setting
    jitter for retries between threads at a lock. There is a
    performance benefit to having jitter, but only if the jitter can
    be generated very quickly and ultimately there is no serious issue
    if no jitter is generated.
    The implementation generally uses 'HP_TIMING_NOW' iff it is
    inlined (avoid any potential syscall paths).
    Reviewed-by: H.J. Lu <>
    (cherry picked from commit 911c63a51c690dd1a97dfc587097277029baf00f)

 sysdeps/generic/fast-jitter.h | 42 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/sysdeps/generic/fast-jitter.h b/sysdeps/generic/fast-jitter.h
new file mode 100644
index 0000000000..4dd53e3475
--- /dev/null
+++ b/sysdeps/generic/fast-jitter.h
@@ -0,0 +1,42 @@
+/* Fallback for fast jitter just return 0.
+   Copyright (C) 2019-2022 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   Lesser General Public License for more details.
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <>.  */
+#ifndef _FAST_JITTER_H
+# define _FAST_JITTER_H
+# include <stdint.h>
+# include <hp-timing.h>
+/* Baseline just return 0.  We could create jitter using a clock or
+   'random_bits' but that may imply a syscall and the goal of
+   'get_fast_jitter' is minimal overhead "randomness" when such
+   randomness helps performance.  Adding high overhead the function
+   defeats the purpose.  */
+static inline uint32_t
+get_fast_jitter (void)
+  hp_timing_t jitter;
+  HP_TIMING_NOW (jitter);
+  return (uint32_t) jitter;
+# else
+  return 0;
+# endif

             reply	other threads:[~2022-09-29 18:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-29 18:41 Sunil Pandey [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-09-28 21:45 Sunil Pandey
2022-09-28 19:11 Sunil Pandey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).