public inbox for glibc-cvs@sourceware.org help / color / mirror / Atom feed
From: Adhemerval Zanella <azanella@sourceware.org> To: glibc-cvs@sourceware.org Subject: [glibc/azanella/clang] x86: Remove __strstr_generic prototype Date: Tue, 4 Oct 2022 12:57:19 +0000 (GMT) [thread overview] Message-ID: <20221004125719.701E4385840C@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=82c0cadf4572f07c4db20c3818088fa45e15e564 commit 82c0cadf4572f07c4db20c3818088fa45e15e564 Author: Adhemerval Zanella <adhemerval.zanella@linaro.org> Date: Mon Mar 14 18:27:33 2022 -0300 x86: Remove __strstr_generic prototype This is not really require and clang throws a attribute declaration must precede definition: ../sysdeps/x86_64/multiarch/strstr.c:37:54: error: attribute declaration must precede definition [-Werror,-Wignored-attributes] extern __typeof (__redirect_strstr) __strstr_generic attribute_hidden; ^ ./../include/libc-symbols.h:423:43: note: expanded from macro 'attribute_hidden' # define attribute_hidden __attribute__ ((visibility ("hidden"))) ^ ../string/strstr.c:76:1: note: previous definition is here STRSTR (const char *haystack, const char *needle) ^ ../sysdeps/x86_64/multiarch/strstr.c:27:16: note: expanded from macro 'STRSTR' #define STRSTR __strstr_generic ^ 1 error generated. Diff: --- sysdeps/x86_64/multiarch/strstr.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sysdeps/x86_64/multiarch/strstr.c b/sysdeps/x86_64/multiarch/strstr.c index 2b83199245..78fad019b2 100644 --- a/sysdeps/x86_64/multiarch/strstr.c +++ b/sysdeps/x86_64/multiarch/strstr.c @@ -34,7 +34,6 @@ #include "string/strstr.c" extern __typeof (__redirect_strstr) __strstr_sse2_unaligned attribute_hidden; -extern __typeof (__redirect_strstr) __strstr_generic attribute_hidden; extern __typeof (__redirect_strstr) __strstr_avx512 attribute_hidden; #include "init-arch.h"
next reply other threads:[~2022-10-04 12:57 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-10-04 12:57 Adhemerval Zanella [this message] 2022-10-28 17:39 Adhemerval Zanella 2023-02-09 19:46 Adhemerval Zanella 2023-08-30 12:34 Adhemerval Zanella 2023-09-28 17:52 Adhemerval Zanella 2023-12-21 18:54 Adhemerval Zanella 2024-01-29 17:57 Adhemerval Zanella 2024-02-07 14:07 Adhemerval Zanella 2024-02-09 17:31 Adhemerval Zanella
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221004125719.701E4385840C@sourceware.org \ --to=azanella@sourceware.org \ --cc=glibc-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).