public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Adhemerval Zanella <azanella@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc/azanella/clang] elf: Supress clang -Wsometimes-uninitialized on _dl_debug_initialize
Date: Tue,  4 Oct 2022 12:58:00 +0000 (GMT)	[thread overview]
Message-ID: <20221004125800.04EC63858C62@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=c98a787b61d9029f6d5c2d9f2be11e23338ff6c6

commit c98a787b61d9029f6d5c2d9f2be11e23338ff6c6
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Wed Aug 24 12:25:05 2022 -0300

    elf: Supress clang -Wsometimes-uninitialized on _dl_debug_initialize
    
    Clang issues an warning where variable 'r' is used uninitialized
    whenever 'if' condition is false.  The _dl_debug_initialize is called
    for static case always with LM_ID_BASE (csu/libc-start.c and
    elf/dl-reloc-static-pie.c) and DL_NSS will be always larger than 1
    for shared case.

Diff:
---
 elf/dl-debug.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/elf/dl-debug.c b/elf/dl-debug.c
index 538468dc0b..74aabeed0d 100644
--- a/elf/dl-debug.c
+++ b/elf/dl-debug.c
@@ -54,7 +54,15 @@ _dl_debug_update (Lmid_t ns)
 struct r_debug *
 _dl_debug_initialize (ElfW(Addr) ldbase, Lmid_t ns)
 {
-  struct r_debug_extended *r, **pp = NULL;
+  /* clang issues an warning where variable 'r' is used uninitialized whenever
+     'if' condition is false.  The _dl_debug_initialize is called for static
+     case always with LM_ID_BASE (csu/libc-start.c and
+     elf/dl-reloc-static-pie.c) and DL_NSS will be always larger than 1 for
+     shared case.  */
+  DIAG_PUSH_NEEDS_COMMENT_CLANG;
+  DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wsometimes-uninitialized");
+  struct r_debug_extended *r;
+  struct r_debug_extended **pp = NULL;
 
   if (ns == LM_ID_BASE)
     {
@@ -81,6 +89,7 @@ _dl_debug_initialize (ElfW(Addr) ldbase, Lmid_t ns)
 	  r->base.r_version = 2;
 	}
     }
+  DIAG_POP_NEEDS_COMMENT_CLANG;
 
   if (r->base.r_brk == 0)
     {

             reply	other threads:[~2022-10-04 12:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-04 12:58 Adhemerval Zanella [this message]
2022-10-28 17:40 Adhemerval Zanella
2023-02-09 19:47 Adhemerval Zanella
2023-08-30 12:35 Adhemerval Zanella
2023-09-28 17:50 Adhemerval Zanella
2023-12-21 18:52 Adhemerval Zanella
2024-01-29 17:55 Adhemerval Zanella
2024-02-07 14:05 Adhemerval Zanella
2024-02-09 17:30 Adhemerval Zanella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221004125800.04EC63858C62@sourceware.org \
    --to=azanella@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).