[glibc/azanella/clang] Suppress clang -Wtautological-constant-out-of-range-compare on strtod_l.c

[Adhemerval Zanella <azanella@sourceware.org>]

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=6e6fe047aba5da8ec7a7298ad8a89337e849ccb4

commit 6e6fe047aba5da8ec7a7298ad8a89337e849ccb4
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Tue Jul 26 08:38:48 2022 -0300

    Suppress clang -Wtautological-constant-out-of-range-compare on strtod_l.c
    
    Clang emits:
    
      strtod_l.c:874:18: error: result of comparison of constant
      9223372036854775807 with expression of type 'size_t' (aka 'unsigned
                        int') is always true
      [-Werror,-Wtautological-constant-out-of-range-compare]
        assert (dig_no <= (uintmax_t) INTMAX_MAX);
        ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~
      ../assert/assert.h:106:11: note: expanded from macro 'assert'
            if (expr)
      \
                ^~~~

Diff:
---
 stdlib/strtod_l.c | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/stdlib/strtod_l.c b/stdlib/strtod_l.c
index 3ebb491e22..ab04c52e8c 100644
--- a/stdlib/strtod_l.c
+++ b/stdlib/strtod_l.c
@@ -85,6 +85,7 @@ extern double ____strtod_l_internal (const char *, char **, int, locale_t);
 #include "fpioconst.h"
 
 #include <assert.h>
+#include <libc-diag.h>
 
 
 /* We use this code for the extended locale handling where the
@@ -871,7 +872,11 @@ ____STRTOF_INTERNAL (const STRING_TYPE *nptr, STRING_TYPE **endptr, int group,
 	  c = *++cp;
 	}
     }
+
+  DIAG_PUSH_NEEDS_COMMENT_CLANG;
+  DIAG_IGNORE_NEEDS_COMMENT_CLANG (13.0, "-Wtautological-constant-out-of-range-compare");
   assert (dig_no <= (uintmax_t) INTMAX_MAX);
+  DIAG_POP_NEEDS_COMMENT_CLANG;
 
   /* Remember start of exponent (if any).  */
   expp = cp;
@@ -901,16 +906,22 @@ ____STRTOF_INTERNAL (const STRING_TYPE *nptr, STRING_TYPE **endptr, int group,
 	    {
 	      if (exp_negative)
 		{
+		  DIAG_PUSH_NEEDS_COMMENT_CLANG;
+		  DIAG_IGNORE_NEEDS_COMMENT_CLANG (13.0, "-Wtautological-constant-out-of-range-compare");
 		  assert (int_no <= (uintmax_t) (INTMAX_MAX
 						 + MIN_EXP - MANT_DIG) / 4);
+		  DIAG_POP_NEEDS_COMMENT_CLANG;
 		  exp_limit = -MIN_EXP + MANT_DIG + 4 * (intmax_t) int_no;
 		}
 	      else
 		{
 		  if (int_no)
 		    {
+		      DIAG_PUSH_NEEDS_COMMENT_CLANG;
+		      DIAG_IGNORE_NEEDS_COMMENT_CLANG (13.0, "-Wtautological-constant-out-of-range-compare");
 		      assert (lead_zero == 0
 			      && int_no <= (uintmax_t) INTMAX_MAX / 4);
+		      DIAG_POP_NEEDS_COMMENT_CLANG;
 		      exp_limit = MAX_EXP - 4 * (intmax_t) int_no + 3;
 		    }
 		  else if (lead_zero == (size_t) -1)
@@ -921,8 +932,11 @@ ____STRTOF_INTERNAL (const STRING_TYPE *nptr, STRING_TYPE **endptr, int group,
 		    }
 		  else
 		    {
+		      DIAG_PUSH_NEEDS_COMMENT_CLANG;
+		      DIAG_IGNORE_NEEDS_COMMENT_CLANG (13.0, "-Wtautological-constant-out-of-range-compare");
 		      assert (lead_zero
 			      <= (uintmax_t) (INTMAX_MAX - MAX_EXP - 3) / 4);
+		      DIAG_POP_NEEDS_COMMENT_CLANG;
 		      exp_limit = (MAX_EXP
 				   + 4 * (intmax_t) lead_zero
 				   + 3);
@@ -933,16 +947,22 @@ ____STRTOF_INTERNAL (const STRING_TYPE *nptr, STRING_TYPE **endptr, int group,
 	    {
 	      if (exp_negative)
 		{
+		  DIAG_PUSH_NEEDS_COMMENT_CLANG;
+		  DIAG_IGNORE_NEEDS_COMMENT_CLANG (13.0, "-Wtautological-constant-out-of-range-compare");
 		  assert (int_no
 			  <= (uintmax_t) (INTMAX_MAX + MIN_10_EXP - MANT_DIG));
+		  DIAG_POP_NEEDS_COMMENT_CLANG;
 		  exp_limit = -MIN_10_EXP + MANT_DIG + (intmax_t) int_no;
 		}
 	      else
 		{
 		  if (int_no)
 		    {
+		      DIAG_PUSH_NEEDS_COMMENT_CLANG;
+		      DIAG_IGNORE_NEEDS_COMMENT_CLANG (13.0, "-Wtautological-constant-out-of-range-compare");
 		      assert (lead_zero == 0
 			      && int_no <= (uintmax_t) INTMAX_MAX);
+		      DIAG_POP_NEEDS_COMMENT_CLANG;
 		      exp_limit = MAX_10_EXP - (intmax_t) int_no + 1;
 		    }
 		  else if (lead_zero == (size_t) -1)
@@ -953,8 +973,11 @@ ____STRTOF_INTERNAL (const STRING_TYPE *nptr, STRING_TYPE **endptr, int group,
 		    }
 		  else
 		    {
+		      DIAG_PUSH_NEEDS_COMMENT_CLANG;
+		      DIAG_IGNORE_NEEDS_COMMENT_CLANG (13.0, "-Wtautological-constant-out-of-range-compare");
 		      assert (lead_zero
 			      <= (uintmax_t) (INTMAX_MAX - MAX_10_EXP - 1));
+		      DIAG_POP_NEEDS_COMMENT_CLANG;
 		      exp_limit = MAX_10_EXP + (intmax_t) lead_zero + 1;
 		    }
 		}