public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Adhemerval Zanella <azanella@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc] posix: Suppress -Os warnings on fnmatch
Date: Wed, 5 Oct 2022 21:43:34 +0000 (GMT) [thread overview]
Message-ID: <20221005214334.A693C3857C7D@sourceware.org> (raw)
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=9ec1c8cd243e9d7d63e188620a7e70a3b69777e6
commit 9ec1c8cd243e9d7d63e188620a7e70a3b69777e6
Author: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
Date: Wed Sep 21 10:51:04 2022 -0300
posix: Suppress -Os warnings on fnmatch
GCC with -Os issues some may uninitialized warnings on fnmatch code.
All of the variables are already set when they are accessed on the
loop prior.
Checked on x86_64-linux-gnu and i686-linux-gnu.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
Diff:
---
posix/fnmatch_loop.c | 31 +++++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)
diff --git a/posix/fnmatch_loop.c b/posix/fnmatch_loop.c
index 9445ed9c58..23eeffc79c 100644
--- a/posix/fnmatch_loop.c
+++ b/posix/fnmatch_loop.c
@@ -530,6 +530,14 @@ FCT (const CHAR *pattern, const CHAR *string, const CHAR *string_end,
{
/* Compare the byte sequence but only if
this is not part of a range. */
+
+ /* The compiler might warn that idx may be
+ used uninitialized, however it will be
+ reached iff elem < table_size which means
+ that it was properly set in the loop
+ above. */
+ DIAG_PUSH_NEEDS_COMMENT;
+ DIAG_IGNORE_Os_NEEDS_COMMENT (8, "-Wmaybe-uninitialized");
if (! is_range
# if WIDE_CHAR_VERSION
@@ -542,11 +550,19 @@ FCT (const CHAR *pattern, const CHAR *string, const CHAR *string_end,
n += c1 - 1;
goto matched;
}
+ DIAG_POP_NEEDS_COMMENT;
/* Get the collation sequence value. */
is_seqval = true;
# if WIDE_CHAR_VERSION
+ /* The compile might warn that wextra may be
+ used uninitialized and similar to 'idx'
+ above it will be properly set by the loop.
+ */
+ DIAG_PUSH_NEEDS_COMMENT;
+ DIAG_IGNORE_Os_NEEDS_COMMENT (8, "-Wmaybe-uninitialized");
cold = wextra[1 + wextra[0]];
+ DIAG_POP_NEEDS_COMMENT;
# else
idx += 1 + extra[idx];
/* Adjust for the alignment. */
@@ -723,9 +739,24 @@ FCT (const CHAR *pattern, const CHAR *string, const CHAR *string_end,
/* Get the collation sequence value. */
is_seqval = true;
# if WIDE_CHAR_VERSION
+ /* The compiler might warn that wextra may
+ be used uninitialized, however it will
+ be reached iff elem < table_size which
+ means that it was properly set in the
+ loop above. */
+ DIAG_PUSH_NEEDS_COMMENT;
+ DIAG_IGNORE_Os_NEEDS_COMMENT (8, "-Wmaybe-uninitialized");
cend = wextra[1 + wextra[0]];
+ DIAG_POP_NEEDS_COMMENT;
# else
+ /* The compile might warn that idx may
+ be used uninitialized and similar to
+ wextra above it will be properly set by
+ the loop. */
+ DIAG_PUSH_NEEDS_COMMENT;
+ DIAG_IGNORE_Os_NEEDS_COMMENT (8, "-Wmaybe-uninitialized");
idx += 1 + extra[idx];
+ DIAG_POP_NEEDS_COMMENT;
/* Adjust for the alignment. */
idx = (idx + 3) & ~3;
cend = *((int32_t *) &extra[idx]);
reply other threads:[~2022-10-05 21:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221005214334.A693C3857C7D@sourceware.org \
--to=azanella@sourceware.org \
--cc=glibc-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).