public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Adhemerval Zanella <azanella@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc] arm: Enable USE_ATOMIC_COMPILER_BUILTINS (BZ #24774)
Date: Fri,  7 Oct 2022 20:33:10 +0000 (GMT)	[thread overview]
Message-ID: <20221007203310.67F5F3858CDB@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=f9646d138f568ced95b29c20efdf902063c7ea96

commit f9646d138f568ced95b29c20efdf902063c7ea96
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Tue Sep 28 17:53:28 2021 +0000

    arm: Enable USE_ATOMIC_COMPILER_BUILTINS (BZ #24774)
    
    As per other architectures.  I have checked on a armv8 hardware with
    the following configurations:
    
      arm-linux-gnueabihf (gcc built with --with-float=hard --with-cpu=arm926ej-s)
      armv5-linux-gnueabihf (-march=armv5te -mfpu=vfpv3)
      armv7-linux-gnueabihf (-march=armv7-a -mfpu=vfpv3)
      armv7-thumb-linux-gnueabihf (-march=armv7-a -mfpu=vfpv3 -mthumb)
      armv7-neon-linux-gnueabihf (-march=armv7-a -mfpu=neon)
      armv7-neonhard-linux-gnueabihf (-march=armv7-a -mfpu=neon -mfloat-abi=hard)
    
    Without any regression.
    
    I haven't dig into the code, but since Linux atomic-machine.h handle
    pre-ARMv6 and ARMv6 I expect the compiler might have some small room
    to optimize.
    
    The code size also improves is most of the configurations:
    
    * master
    
       text    data     bss     dec     hex filename
    1727801    9720   37928 1775449  1b1759  arm-linux-gnueabihf/libc.so
    1691729    9720   37928 1739377  1a8a71  arm-linux-gnueabihf-armv7-disable-multi-arch/libc.so
    1725509    9720   37928 1773157  1b0e65  armv5-linux-gnueabihf/libc.so
    1700757    9720   37928 1748405  1aadb5  armv6-linux-gnueabihf/libc.so
    1698973    9720   37928 1746621  1aa6bd  armv6t2-linux-gnueabihf/libc.so
    1695481    9752   37928 1743161  1a9939  armv7-linux-gnueabihf/libc.so
    1692917    9744   37928 1740589  1a8f2d  armv7-neonhard-linux-gnueabihf/libc.so
    1692917    9744   37928 1740589  1a8f2d  armv7-neon-linux-gnueabihf/libc.so
    1225353    9752   37928 1273033  136cc9  armv7-thumb-linux-gnueabihf/libc.so
    
    * patched
    
       text    data     bss     dec     hex filename
    1726805    9720   37928 1774453  1b1375 arm-linux-gnueabihf/libc.so
    1689321    9720   37928 1736969  1a8109 arm-linux-gnueabihf-armv7-disable-multi-arch/libc.so
    1724433    9720   37928 1772081  1b0a31 armv5-linux-gnueabihf/libc.so
    1698301    9720   37928 1745949  1aa41d armv6-linux-gnueabihf/libc.so
    1696525    9720   37928 1744173  1a9d2d armv6t2-linux-gnueabihf/libc.so
    1693009    9752   37928 1740689  1a8f91 armv7-linux-gnueabihf/libc.so
    1690493    9744   37928 1738165  1a85b5 armv7-neonhard-linux-gnueabihf/libc.so
    1690493    9744   37928 1738165  1a85b5 armv7-neon-linux-gnueabihf/libc.so
    1223837    9752   37928 1271517  1366dd armv7-thumb-linux-gnueabihf/libc.so
    
    The idea is eventually move all architectures to use compiler builtins.
    
    Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>
    Tested-by: Aurelien Jarno <aurelien@aurel32.net>

Diff:
---
 sysdeps/arm/atomic-machine.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sysdeps/arm/atomic-machine.h b/sysdeps/arm/atomic-machine.h
index 9524043797..e1f7731df0 100644
--- a/sysdeps/arm/atomic-machine.h
+++ b/sysdeps/arm/atomic-machine.h
@@ -17,7 +17,7 @@
    <https://www.gnu.org/licenses/>.  */
 
 #define __HAVE_64B_ATOMICS 0
-#define USE_ATOMIC_COMPILER_BUILTINS 0
+#define USE_ATOMIC_COMPILER_BUILTINS 1
 #define ATOMIC_EXCHANGE_USES_CAS 1
 
 void __arm_link_error (void);

                 reply	other threads:[~2022-10-07 20:33 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221007203310.67F5F3858CDB@sourceware.org \
    --to=azanella@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).