public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Szabolcs Nagy <nsz@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc/arm/morello/main] cheri: elf: make sure dlpi_phdr covers the load segments
Date: Wed, 12 Oct 2022 14:18:37 +0000 (GMT)	[thread overview]
Message-ID: <20221012141837.89AD0384D1AE@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=c0a839639b6a9baeaafe5dad8f7739e6176a2c62

commit c0a839639b6a9baeaafe5dad8f7739e6176a2c62
Author: Szabolcs Nagy <szabolcs.nagy@arm.com>
Date:   Wed Sep 14 14:04:18 2022 +0100

    cheri: elf: make sure dlpi_phdr covers the load segments
    
    In dl_iterate_phdr phdr is the only capability passed to the callback
    that may be used to derive pointers of the elf module, so ensure it
    has wide bounds.

Diff:
---
 elf/dl-iteratephdr.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/elf/dl-iteratephdr.c b/elf/dl-iteratephdr.c
index 146850b88a..bd2588fae8 100644
--- a/elf/dl-iteratephdr.c
+++ b/elf/dl-iteratephdr.c
@@ -69,7 +69,12 @@ __dl_iterate_phdr (int (*callback) (struct dl_phdr_info *info,
       info.dlpi_addr = l->l_real->l_addr;
 #endif
       info.dlpi_name = l->l_real->l_name;
+#ifdef __CHERI_PURE_CAPABILITY__
+      ElfW(Addr) phdr = (ElfW(Addr)) l->l_real->l_phdr - l->l_real->l_addr;
+      info.dlpi_phdr = (const void *) dl_rx_ptr (l->l_real, phdr);
+#else
       info.dlpi_phdr = l->l_real->l_phdr;
+#endif
       info.dlpi_phnum = l->l_real->l_phnum;
       info.dlpi_adds = GL(dl_load_adds);
       info.dlpi_subs = GL(dl_load_adds) - nloaded;

             reply	other threads:[~2022-10-12 14:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-12 14:18 Szabolcs Nagy [this message]
2022-10-26 15:21 Szabolcs Nagy
2022-10-27 13:59 Szabolcs Nagy
2022-11-23 14:49 Szabolcs Nagy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221012141837.89AD0384D1AE@sourceware.org \
    --to=nsz@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).