From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1944) id 5D700385382D; Wed, 26 Oct 2022 15:07:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5D700385382D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666796875; bh=v5MxLlsJpkYD0w37RMBM+kUEAa3w0VHqwu7rO19zg3o=; h=From:To:Subject:Date:From; b=a27lvoQNUVEkcEplSXuILnbyV/8+c8bUj2zq3ADJu+WMTWQt46UtRTgXiLI44IvAS Aed6seP5EoxOq4DvoLp0OnuxkuKdJ8wZJ2/vXdjf3KS0zuSuqXS3UBN9tF2eajAEg+ tucHDO36CGfy3HfbPUdoqx1nR1dfs59f0N7dTXz8= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Szabolcs Nagy To: glibc-cvs@sourceware.org Subject: [glibc/arm/morello/main] gconv: Use 64-bit interfaces in gconv_parseconfdir (bug 29583) X-Act-Checkin: glibc X-Git-Author: Florian Weimer X-Git-Refname: refs/heads/arm/morello/main X-Git-Oldrev: da5f134f6d59701a3a6119309ae91c93c3fa5b51 X-Git-Newrev: 52c037f3574eb9062b111d78a4cbeb79681d07d3 Message-Id: <20221026150755.5D700385382D@sourceware.org> Date: Wed, 26 Oct 2022 15:07:55 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=52c037f3574eb9062b111d78a4cbeb79681d07d3 commit 52c037f3574eb9062b111d78a4cbeb79681d07d3 Author: Florian Weimer Date: Tue Sep 20 12:12:43 2022 +0200 gconv: Use 64-bit interfaces in gconv_parseconfdir (bug 29583) It's possible that inode numbers are outside the 32-bit range. The existing code only handles the in-libc case correctly, and still uses the legacy interfaces when building iconv. Suggested-by: Helge Deller (cherry picked from commit f97905f24631097af325d6a231093071c3077a5f) Diff: --- NEWS | 1 + iconv/gconv_parseconfdir.h | 16 ++++++++-------- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/NEWS b/NEWS index 5b4753416f..eab882987b 100644 --- a/NEWS +++ b/NEWS @@ -26,6 +26,7 @@ The following bugs are resolved with this release: [29490] alpha: New __brk_call implementation is broken [29528] elf: Call __libc_early_init for reused namespaces [29539] libc: LD_TRACE_LOADED_OBJECTS changed how vDSO library are + [29583] Use 64-bit interfaces in gconv_parseconfdir Version 2.36 diff --git a/iconv/gconv_parseconfdir.h b/iconv/gconv_parseconfdir.h index debb96b322..b72933b526 100644 --- a/iconv/gconv_parseconfdir.h +++ b/iconv/gconv_parseconfdir.h @@ -29,14 +29,14 @@ # define isspace(__c) __isspace_l ((__c), _nl_C_locobj_ptr) # define asprintf __asprintf # define opendir __opendir -# define readdir __readdir +# define readdir64 __readdir64 # define closedir __closedir # define mempcpy __mempcpy -# define struct_stat struct __stat64_t64 -# define lstat __lstat64_time64 +# define struct_stat64 struct __stat64_t64 +# define lstat64 __lstat64_time64 # define feof_unlocked __feof_unlocked #else -# define struct_stat struct stat +# define struct_stat64 struct stat64 #endif /* Name of the file containing the module information in the directories @@ -148,8 +148,8 @@ gconv_parseconfdir (const char *prefix, const char *dir, size_t dir_len) DIR *confdir = opendir (buf); if (confdir != NULL) { - struct dirent *ent; - while ((ent = readdir (confdir)) != NULL) + struct dirent64 *ent; + while ((ent = readdir64 (confdir)) != NULL) { if (ent->d_type != DT_REG && ent->d_type != DT_UNKNOWN) continue; @@ -161,12 +161,12 @@ gconv_parseconfdir (const char *prefix, const char *dir, size_t dir_len) && strcmp (ent->d_name + len - strlen (suffix), suffix) == 0) { char *conf; - struct_stat st; + struct_stat64 st; if (asprintf (&conf, "%s/%s", buf, ent->d_name) < 0) continue; if (ent->d_type != DT_UNKNOWN - || (lstat (conf, &st) != -1 && S_ISREG (st.st_mode))) + || (lstat64 (conf, &st) != -1 && S_ISREG (st.st_mode))) found |= read_conf_file (conf, dir, dir_len); free (conf);