From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1944) id 62225385150F; Wed, 26 Oct 2022 15:09:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 62225385150F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666796946; bh=AXKbwQOO5NtTcvsjwGnLZ/dodA4WHvgmS8PQAVf2m98=; h=From:To:Subject:Date:From; b=aGbGH7bv71KnkB+1HL+WDeReJnX3Y/jiDureM/6MEMm/Pop7kyvtykkxj+w7HHs8N hk7nQsz+HYNI2xbv3n1pBvmozwJLk4goGe/blf2vVxQIMnAcaZowkM5YLcwfsPdHrX wglbnmfqSFpUXQdxcrz/zp7G4nSnwl0gFWzhU5WU= MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" From: Szabolcs Nagy To: glibc-cvs@sourceware.org Subject: [glibc/arm/morello/main] nscd: Drop local address tuple variable [BZ #29607] X-Act-Checkin: glibc X-Git-Author: Siddhesh Poyarekar X-Git-Refname: refs/heads/arm/morello/main X-Git-Oldrev: 2d8ef784bd6a784496a6fd460de6b6f57c70a501 X-Git-Newrev: 2bd815d8347851212b9a91dbdca8053f4dbdac87 Message-Id: <20221026150906.62225385150F@sourceware.org> Date: Wed, 26 Oct 2022 15:09:06 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=2bd815d8347851212b9a91dbdca8053f4dbdac87 commit 2bd815d8347851212b9a91dbdca8053f4dbdac87 Author: Siddhesh Poyarekar Date: Tue Oct 4 18:43:50 2022 -0400 nscd: Drop local address tuple variable [BZ #29607] When a request needs to be resent (e.g. due to insufficient buffer space), the references to subsequent tuples in the local variable are stale and should not be used. This used to work by accident before, but since 1d495912a it no longer does. Instead of trying to reset it, just let gethostbyname4_r write into TUMPBUF6 for us, thus maintaining a consistent state at all times. This is now consistent with what is done in gaih_inet for getaddrinfo. Resolves: BZ #29607 Reported-by: Holger Hoffstätte Tested-by: Holger Hoffstätte Reviewed-by: Carlos O'Donell (cherry picked from commit 6e33e5c4b73cea7b8aa3de0947123db16200fb65) Diff: --- NEWS | 2 ++ nscd/aicache.c | 5 ++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/NEWS b/NEWS index 91bcfeb7a6..63e26d7062 100644 --- a/NEWS +++ b/NEWS @@ -28,6 +28,8 @@ The following bugs are resolved with this release: [29537] libc: [2.34 regression]: Alignment issue on m68k when using [29539] libc: LD_TRACE_LOADED_OBJECTS changed how vDSO library are [29583] Use 64-bit interfaces in gconv_parseconfdir + [29607] nscd repeatably crashes calling __strlen_avx2 when hosts cache is + enabled [29638] libc: stdlib: arc4random fallback is never used Version 2.36 diff --git a/nscd/aicache.c b/nscd/aicache.c index 51e793199f..e0baed170b 100644 --- a/nscd/aicache.c +++ b/nscd/aicache.c @@ -110,11 +110,10 @@ addhstaiX (struct database_dyn *db, int fd, request_header *req, "gethostbyname4_r"); if (fct4 != NULL) { - struct gaih_addrtuple atmem; struct gaih_addrtuple *at; while (1) { - at = &atmem; + at = NULL; rc6 = 0; herrno = 0; status[1] = DL_CALL_FCT (fct4, (key, &at, @@ -137,7 +136,7 @@ addhstaiX (struct database_dyn *db, int fd, request_header *req, goto next_nip; /* We found the data. Count the addresses and the size. */ - for (const struct gaih_addrtuple *at2 = at = &atmem; at2 != NULL; + for (const struct gaih_addrtuple *at2 = at; at2 != NULL; at2 = at2->next) { ++naddrs;