public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Szabolcs Nagy <nsz@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc/arm/morello/main] Fix missing NUL terminator in stdio-common/scanf13 test
Date: Wed, 26 Oct 2022 15:10:42 +0000 (GMT)	[thread overview]
Message-ID: <20221026151042.C17AF385152F@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=a4a231893f5af8a532cfd149dd71253d9183f600

commit a4a231893f5af8a532cfd149dd71253d9183f600
Author: Szabolcs Nagy <szabolcs.nagy@arm.com>
Date:   Tue Oct 11 14:57:16 2022 +0100

    Fix missing NUL terminator in stdio-common/scanf13 test
    
    sscanf is only defined on nul terminated string input, but '\0' was
    missing in this test which caused _IO_str_init_static_internal to
    read OOB on the stack when computing the bounds of the string.

Diff:
---
 stdio-common/scanf13.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/stdio-common/scanf13.c b/stdio-common/scanf13.c
index 720224aa05..60aa62a26f 100644
--- a/stdio-common/scanf13.c
+++ b/stdio-common/scanf13.c
@@ -67,6 +67,7 @@ main (void)
   buf[2049] = 0x84;
   buf[2058] = '\t';
   buf[2059] = 'a';
+  buf[sizeof (buf) - 1] = '\0';
   if (sscanf (buf, "%ms%mc", &sp1, &sp2) != 2)
     FAIL ();
   else

             reply	other threads:[~2022-10-26 15:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-26 15:10 Szabolcs Nagy [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-11-23 14:39 Szabolcs Nagy
2022-10-27 13:49 Szabolcs Nagy
2022-10-12 14:15 Szabolcs Nagy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221026151042.C17AF385152F@sourceware.org \
    --to=nsz@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).