public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Szabolcs Nagy <nsz@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc/arm/morello/main] cheri: don't use dl_random for pointer mangling
Date: Wed, 26 Oct 2022 15:16:13 +0000 (GMT)	[thread overview]
Message-ID: <20221026151613.49938388302A@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=72aca7d8eb54c2a44b2d1b13e5b84dc874241c1e

commit 72aca7d8eb54c2a44b2d1b13e5b84dc874241c1e
Author: Szabolcs Nagy <szabolcs.nagy@arm.com>
Date:   Tue Mar 1 17:36:12 2022 +0000

    cheri: don't use dl_random for pointer mangling
    
    Pointer mangling cannot be supported on capability architectures.
    And there is not enough bytes in dl_random for 128 bit pointers.
    
    Stack guard is still loaded from dl_random: stack protection is
    unlikely to be useful on a capability architecture, but it works.

Diff:
---
 sysdeps/unix/sysv/linux/dl-osinfo.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/sysdeps/unix/sysv/linux/dl-osinfo.h b/sysdeps/unix/sysv/linux/dl-osinfo.h
index 49d8f973c8..c5d864f5ba 100644
--- a/sysdeps/unix/sysv/linux/dl-osinfo.h
+++ b/sysdeps/unix/sysv/linux/dl-osinfo.h
@@ -52,7 +52,12 @@ _dl_setup_stack_chk_guard (void *dl_random)
 static inline uintptr_t __attribute__ ((always_inline))
 _dl_setup_pointer_guard (void *dl_random, uintptr_t stack_chk_guard)
 {
+#ifdef __CHERI_PURE_CAPABILITY__
+  /* Pointer mangling is not supported on capability architectures.  */
+  return 0;
+#else
   uintptr_t ret;
   memcpy (&ret, (char *) dl_random + sizeof (ret), sizeof (ret));
   return ret;
+#endif
 }

             reply	other threads:[~2022-10-26 15:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-26 15:16 Szabolcs Nagy [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-11-23 14:44 Szabolcs Nagy
2022-10-27 13:54 Szabolcs Nagy
2022-08-05 19:33 Szabolcs Nagy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221026151613.49938388302A@sourceware.org \
    --to=nsz@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).