From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1944) id AB764384642B; Wed, 26 Oct 2022 15:17:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AB764384642B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666797465; bh=w1RcNW4Pw+B2RGJCaFtom/w/mS+V3Z12X1com7laKps=; h=From:To:Subject:Date:From; b=wn7GQUfdwoAUWpFPmv9h5OssaHEiydCYJTKYz/cabSZqDqOe8McM7smJCzqxBlSmK iCAWtn9L1ydQZ6nDnYs8NmyMzZJ2S8kDJCYqSwySIj3IFUHPH5tzyfppGvGpYUiYpe cdaXzwqSvrWwLVzO2iiUpaabSSPFbpyGPQ/cgBnk= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Szabolcs Nagy To: glibc-cvs@sourceware.org Subject: [glibc/arm/morello/main] cheri: Fix capability permissions of PROT_NONE map in locarchive X-Act-Checkin: glibc X-Git-Author: Szabolcs Nagy X-Git-Refname: refs/heads/arm/morello/main X-Git-Oldrev: 3d59fb52744155021dc50b70d48470cd2810d593 X-Git-Newrev: 76bb30167b4e28a44e61e94e9b2474dc939c8ab5 Message-Id: <20221026151745.AB764384642B@sourceware.org> Date: Wed, 26 Oct 2022 15:17:45 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=76bb30167b4e28a44e61e94e9b2474dc939c8ab5 commit 76bb30167b4e28a44e61e94e9b2474dc939c8ab5 Author: Szabolcs Nagy Date: Tue Oct 25 11:20:48 2022 +0100 cheri: Fix capability permissions of PROT_NONE map in locarchive Diff: --- locale/programs/locarchive.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/locale/programs/locarchive.c b/locale/programs/locarchive.c index eeb2fa6ffe..81a980b60b 100644 --- a/locale/programs/locarchive.c +++ b/locale/programs/locarchive.c @@ -84,6 +84,13 @@ static const char *locnames[] = /* Size of the reserved address space area. */ #define RESERVE_MMAP_SIZE 512 * 1024 * 1024 +/* On CHERI targets ensure the mmap returned capability has RW permissions. */ +#ifdef PROT_MAX +# define PROT_MAX_RW PROT_MAX (PROT_READ | PROT_WRITE) +#else +# define PROT_MAX_RW 0 +#endif + /* To prepare for enlargements of the mmaped area reserve some address space. On some machines, being a file mapping rather than an anonymous mapping affects the address selection. So do this mapping from the @@ -94,7 +101,8 @@ prepare_address_space (int fd, size_t total, size_t *reserved, int *xflags, { if (total < RESERVE_MMAP_SIZE) { - void *p = mmap64 (NULL, RESERVE_MMAP_SIZE, PROT_NONE, MAP_SHARED, fd, 0); + void *p = mmap64 (NULL, RESERVE_MMAP_SIZE, + PROT_NONE | PROT_MAX_RW, MAP_SHARED, fd, 0); if (p != MAP_FAILED) { void *aligned_p = PTR_ALIGN_UP (p, MAP_FIXED_ALIGNMENT);