public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Szabolcs Nagy <nsz@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc/arm/morello/main] TODO(api): cheri: fix dl_iterate_phdr dlpi_addr
Date: Wed, 26 Oct 2022 15:20:55 +0000 (GMT)	[thread overview]
Message-ID: <20221026152055.7F9BE3882148@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=40ede395252b8dfedabd2cf3bcff1ee87d94e2ee

commit 40ede395252b8dfedabd2cf3bcff1ee87d94e2ee
Author: Szabolcs Nagy <szabolcs.nagy@arm.com>
Date:   Wed Sep 7 17:37:38 2022 +0100

    TODO(api): cheri: fix dl_iterate_phdr dlpi_addr
    
    The dlpi_addr field is a capability that has value l_addr, but we can
    only do this for libraries (ET_DYN) where l_addr == l_map_start,
    otherwise we return l_addr which is normally 0 then (ET_EXEC) so the
    caller can detect and special case it.
    
    For now l_addr != 0 and l_addr != l_map_start case is not supported.
    Note: this api may be used by the unwinder to find and read .eh_frame
    data.
    
    TODO: dlpi_addr could be address only, but requires unwinder update
    and agreement about the abi.

Diff:
---
 elf/dl-iteratephdr.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/elf/dl-iteratephdr.c b/elf/dl-iteratephdr.c
index 4d12a8ed50..146850b88a 100644
--- a/elf/dl-iteratephdr.c
+++ b/elf/dl-iteratephdr.c
@@ -61,7 +61,13 @@ __dl_iterate_phdr (int (*callback) (struct dl_phdr_info *info,
 
   for (l = GL(dl_ns)[ns]._ns_loaded; l != NULL; l = l->l_next)
     {
+#ifdef __CHERI_PURE_CAPABILITY__
+      info.dlpi_addr = l->l_real->l_addr == l->l_real->l_map_start
+		       ? l->l_real->l_map_start
+		       : l->l_real->l_addr;
+#else
       info.dlpi_addr = l->l_real->l_addr;
+#endif
       info.dlpi_name = l->l_real->l_name;
       info.dlpi_phdr = l->l_real->l_phdr;
       info.dlpi_phnum = l->l_real->l_phnum;

             reply	other threads:[~2022-10-26 15:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-26 15:20 Szabolcs Nagy [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-11-23 14:49 Szabolcs Nagy
2022-10-27 13:59 Szabolcs Nagy
2022-10-12 14:18 Szabolcs Nagy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221026152055.7F9BE3882148@sourceware.org \
    --to=nsz@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).