public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Szabolcs Nagy <nsz@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc/arm/morello/main] static: glibc-bug: NL_CURRENT_INDIRECT is broken so disable it
Date: Thu, 27 Oct 2022 13:50:23 +0000 (GMT)	[thread overview]
Message-ID: <20221027135023.5740E3865C1F@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=1604aadbdf88b72dd69183f69fa022f3d90ac20b

commit 1604aadbdf88b72dd69183f69fa022f3d90ac20b
Author: Szabolcs Nagy <szabolcs.nagy@arm.com>
Date:   Fri Mar 18 10:14:58 2022 +0000

    static: glibc-bug: NL_CURRENT_INDIRECT is broken so disable it
    
    nl_langinfo_l ignores its locale argument with NL_CURRENT_INDIRECT
    which is wrong when that argument does not match the current thread's
    locale.
    
    upstream glibc is not tested with static linking so this is not found.

Diff:
---
 locale/localeinfo.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/locale/localeinfo.h b/locale/localeinfo.h
index fd43033a19..addb9e0ca6 100644
--- a/locale/localeinfo.h
+++ b/locale/localeinfo.h
@@ -247,8 +247,8 @@ __libc_tsd_define (extern, locale_t, LOCALE)
    But with thread-local locale settings, it becomes quite ungainly unless
    we can use __thread variables.  So only in that case do we attempt this.  */
 #ifndef SHARED
-# include <tls.h>
-# define NL_CURRENT_INDIRECT	1
+//# include <tls.h>
+//# define NL_CURRENT_INDIRECT	1
 #endif
 
 #ifdef NL_CURRENT_INDIRECT

             reply	other threads:[~2022-10-27 13:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-27 13:50 Szabolcs Nagy [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-11-23 14:40 Szabolcs Nagy
2022-10-26 15:11 Szabolcs Nagy
2022-10-12 14:16 Szabolcs Nagy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221027135023.5740E3865C1F@sourceware.org \
    --to=nsz@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).