public inbox for glibc-cvs@sourceware.org help / color / mirror / Atom feed
From: Szabolcs Nagy <nsz@sourceware.org> To: glibc-cvs@sourceware.org Subject: [glibc/arm/morello/main] cheri: malloc: Ensure the mappings have RW permission Date: Thu, 27 Oct 2022 13:57:10 +0000 (GMT) [thread overview] Message-ID: <20221027135710.6054D3851503@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=af11ceae3867a3786308738a6870a8f1016a865e commit af11ceae3867a3786308738a6870a8f1016a865e Author: Szabolcs Nagy <szabolcs.nagy@arm.com> Date: Fri Oct 21 12:35:33 2022 +0100 cheri: malloc: Ensure the mappings have RW permission The arena allocator incrementally applies RW mprotect to a PROT_NONE mapping. Use PROT_MAX to ensure the pointers derived from the original mapping have RW capability permission. Diff: --- malloc/malloc.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/malloc/malloc.c b/malloc/malloc.c index 02df29d2ad..701adbebca 100644 --- a/malloc/malloc.c +++ b/malloc/malloc.c @@ -1134,8 +1134,16 @@ static mchunkptr mremap_chunk(mchunkptr p, size_t new_size); # define MAP_NORESERVE 0 #endif +/* Allow RW mprotect later, on CHERI this means RW capability permission. */ +#ifdef PROT_MAX +# define PROT_MAX_RW PROT_MAX (PROT_READ | PROT_WRITE) +#else +# define PROT_MAX_RW 0 +#endif + #define MMAP(addr, size, prot, flags) \ - __mmap((addr), (size), (prot), (flags)|MAP_ANONYMOUS|MAP_PRIVATE, -1, 0) + __mmap((addr), (size), (prot)|PROT_MAX_RW, \ + (flags)|MAP_ANONYMOUS|MAP_PRIVATE, -1, 0) /*
next reply other threads:[~2022-10-27 13:57 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-10-27 13:57 Szabolcs Nagy [this message] -- strict thread matches above, loose matches on Subject: below -- 2022-11-23 14:46 Szabolcs Nagy 2022-10-26 15:18 Szabolcs Nagy 2022-10-26 14:49 Szabolcs Nagy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221027135710.6054D3851503@sourceware.org \ --to=nsz@sourceware.org \ --cc=glibc-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).