public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Szabolcs Nagy <nsz@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc/arm/morello/main] TODO(sprof): cheri: disable profiling shared libraries
Date: Thu, 27 Oct 2022 13:58:23 +0000 (GMT)	[thread overview]
Message-ID: <20221027135823.2D3133851530@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=010cf0128e02429c8686772f20cf80b2ca678939

commit 010cf0128e02429c8686772f20cf80b2ca678939
Author: Szabolcs Nagy <szabolcs.nagy@arm.com>
Date:   Thu May 12 09:05:30 2022 +0100

    TODO(sprof): cheri: disable profiling shared libraries
    
    This is needed now to avoid referencing abort in ld.so.
    
    TODO: Fixing shared library profiling for capabilities requires
    type fixes so capabilities are not stored into shared memory
    (maybe purecap layout can match the lp64 one and then no file format
    and external tooling change is required.)
    TODO: Proper fix also depends on _dl_runtime_profile plt entry

Diff:
---
 elf/dl-profile.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/elf/dl-profile.c b/elf/dl-profile.c
index ec57e3a965..2cb66e83c6 100644
--- a/elf/dl-profile.c
+++ b/elf/dl-profile.c
@@ -182,6 +182,9 @@ static unsigned int log_hashfraction;
 void
 _dl_start_profile (void)
 {
+#ifdef __CHERI_PURE_CAPABILITY__
+  __libc_fatal ("Profiling is not supported on capability architectures.");
+#else
   char *filename;
   int fd;
   struct __stat64_t64 st;
@@ -482,6 +485,7 @@ _dl_start_profile (void)
 
   /* Turn on profiling.  */
   running = 1;
+#endif
 }

             reply	other threads:[~2022-10-27 13:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-27 13:58 Szabolcs Nagy [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-11-23 14:48 Szabolcs Nagy
2022-10-26 15:19 Szabolcs Nagy
2022-08-05 19:38 Szabolcs Nagy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221027135823.2D3133851530@sourceware.org \
    --to=nsz@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).