From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1944) id 4FA823851517; Thu, 27 Oct 2022 13:59:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4FA823851517 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666879179; bh=blMQp1Iou+nHYZ9O+Jz/W0ruutCXhIQ24+HKpf5tlkg=; h=From:To:Subject:Date:From; b=n9c3iPYGMzdBIB9lI/3q+DXlNCgOMLNOPNTgNeMZ8WaSm2rKt7CIuYLfcq3RZ1dse u7Kxu7MAQg5GNFHzCK9GQ63Ozn0UeBsVqPwH9IvRi2e6owoiqm+czi2+4YVFADHEap 0xGOk0VNDhyTZOVinuper7+i5Cn6IDSH5E6GnvGo= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Szabolcs Nagy To: glibc-cvs@sourceware.org Subject: [glibc/arm/morello/main] cheri: fix posix timers X-Act-Checkin: glibc X-Git-Author: Szabolcs Nagy X-Git-Refname: refs/heads/arm/morello/main X-Git-Oldrev: ac41cba6b4853b22ce09697dfcfcd901b69f717a X-Git-Newrev: 52d4224dd26a601b13e41467703c784e1b14ad9d Message-Id: <20221027135939.4FA823851517@sourceware.org> Date: Thu, 27 Oct 2022 13:59:39 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=52d4224dd26a601b13e41467703c784e1b14ad9d commit 52d4224dd26a601b13e41467703c784e1b14ad9d Author: Szabolcs Nagy Date: Tue Apr 19 15:18:56 2022 +0100 cheri: fix posix timers We need to distinguish timerids that are small integers returned by the kernel and timerids that are pointers to struct timer. The existing pointer tagging does not work for CHERI because of the pointer shift. Simply use the top bit without shift to tag pointers. This still relies on the top byte ignore of aarch64 (the top byte does not affect the capability representation) and that pointers are not tagged for other reasons (like HWASAN). Note: this is morello specific and does not work for generic cheri. Diff: --- sysdeps/unix/sysv/linux/kernel-posix-timers.h | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/sysdeps/unix/sysv/linux/kernel-posix-timers.h b/sysdeps/unix/sysv/linux/kernel-posix-timers.h index 82ce92f2ae..371e328258 100644 --- a/sysdeps/unix/sysv/linux/kernel-posix-timers.h +++ b/sysdeps/unix/sysv/linux/kernel-posix-timers.h @@ -79,6 +79,25 @@ kernel_timer_to_timerid (kernel_timer_t ktimerid) return (timer_t) ((intptr_t) ktimerid); } +#ifdef __CHERI_PURE_CAPABILITY__ +static inline timer_t +timer_to_timerid (struct timer *ptr) +{ + return (timer_t) ((uintptr_t) ptr | ~(-1UL/2)); +} + +static inline bool +timer_is_sigev_thread (timer_t timerid) +{ + return ((uintptr_t) timerid & ~(-1UL/2)) != 0; +} + +static inline struct timer * +timerid_to_timer (timer_t timerid) +{ + return (struct timer *)((uintptr_t) timerid & (-1UL/2)); +} +#else static inline timer_t timer_to_timerid (struct timer *ptr) { @@ -96,6 +115,7 @@ timerid_to_timer (timer_t timerid) { return (struct timer *)((uintptr_t) timerid << 1); } +#endif static inline kernel_timer_t timerid_to_kernel_timer (timer_t timerid)