From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1944) id A4EB5385742B; Fri, 28 Oct 2022 10:18:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A4EB5385742B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666952312; bh=RNyZuT+RTfPUSn1VtTbvbFSkIXGehxSLNcQvyJEORyo=; h=From:To:Subject:Date:From; b=vGooKv+Pn6cgfZNKD8FrbsTbOMkiC0g7+ElARw0M47r0Vhqm58vEkY9WT4GYsDe31 gq/B7igVSJss6L9XkTlMazw5Qek9eGGds79yxSoSmNzSfS/qaQRAue9vdGVlfQXpaX rj/J7C6VxwqXG8VF0MJCRd6ngdr6CJcyA9Sv+0gQ= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Szabolcs Nagy To: glibc-cvs@sourceware.org Subject: [glibc] Fix invalid pointer dereference in wcpcpy_chk X-Act-Checkin: glibc X-Git-Author: Szabolcs Nagy X-Git-Refname: refs/heads/master X-Git-Oldrev: e5ece9de1417ac33c755226f3dd962fc2c7d97aa X-Git-Newrev: 3fa20d59d9607e4494dfbc99bacee1935ec5ded9 Message-Id: <20221028101832.A4EB5385742B@sourceware.org> Date: Fri, 28 Oct 2022 10:18:32 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=3fa20d59d9607e4494dfbc99bacee1935ec5ded9 commit 3fa20d59d9607e4494dfbc99bacee1935ec5ded9 Author: Szabolcs Nagy Date: Tue Jun 21 15:57:48 2022 +0100 Fix invalid pointer dereference in wcpcpy_chk The src pointer is const and points to a different object, so accessing dest via src is invalid. Reviewed-by: Florian Weimer Diff: --- debug/wcpcpy_chk.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/debug/wcpcpy_chk.c b/debug/wcpcpy_chk.c index bc2be43c3e..d44fb479d0 100644 --- a/debug/wcpcpy_chk.c +++ b/debug/wcpcpy_chk.c @@ -28,13 +28,12 @@ __wcpcpy_chk (wchar_t *dest, const wchar_t *src, size_t destlen) { wchar_t *wcp = (wchar_t *) dest - 1; wint_t c; - const ptrdiff_t off = src - dest + 1; do { if (__glibc_unlikely (destlen-- == 0)) __chk_fail (); - c = wcp[off]; + c = *src++; *++wcp = c; } while (c != L'\0');