From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1944) id 28D0D385781C; Fri, 28 Oct 2022 10:18:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 28D0D385781C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666952328; bh=lf9ODd9+7yxvjrKZIrHeOSfbr9M4phv6erwWpAGL/Q0=; h=From:To:Subject:Date:From; b=sx1/eO8GoFWLX5fvptYjfIN041gbqS0Whfr9Cq5uJwItaIOxrjMKoRgnGTPLUPxOQ hX+tda7LXnWHMR3vFqZbyW3XsdbE8KJeUmu5W3xdB5eG9l0AW4TKbmXFmMHixTQdm0 fj9oWnHV/hmNav8PK6/IUTt75uCZFzbPQkTgZyLA= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Szabolcs Nagy To: glibc-cvs@sourceware.org Subject: [glibc] Fix off-by-one OOB read in elf/tst-tls20 X-Act-Checkin: glibc X-Git-Author: Szabolcs Nagy X-Git-Refname: refs/heads/master X-Git-Oldrev: eef17d4d9fcd38c5cbb9bc9515ba72d1773b67a2 X-Git-Newrev: 6a3794ea917558776ba1a66a925f2d5e1dbf0724 Message-Id: <20221028101848.28D0D385781C@sourceware.org> Date: Fri, 28 Oct 2022 10:18:48 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=6a3794ea917558776ba1a66a925f2d5e1dbf0724 commit 6a3794ea917558776ba1a66a925f2d5e1dbf0724 Author: Szabolcs Nagy Date: Tue Oct 11 13:07:59 2022 +0100 Fix off-by-one OOB read in elf/tst-tls20 The int mods[nmods] array on the stack was overread by one. Reviewed-by: Florian Weimer Diff: --- elf/tst-tls20.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/elf/tst-tls20.c b/elf/tst-tls20.c index ce4635eeb1..9cebe22a40 100644 --- a/elf/tst-tls20.c +++ b/elf/tst-tls20.c @@ -264,7 +264,7 @@ do_test_dependency (void) xdlclose (moddep); } - for (int n = 1; n <= nmods; n++) + for (int n = 1; n < nmods; n++) if (mods[n] != 0) unload_mod (n); } @@ -342,7 +342,7 @@ do_test_invalid_dependency (bool bind_now) xdlclose (moddep); } - for (int n = 1; n <= nmods; n++) + for (int n = 1; n < nmods; n++) if (mods[n] != 0) unload_mod (n); }