From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 7844) id 9E2873858D20; Wed, 9 Nov 2022 04:33:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9E2873858D20 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1667968418; bh=ydzNnrsaSZCwCzFqbBYQ+rgf1HAoYGzXNh4Bj9eW1Gc=; h=From:To:Subject:Date:From; b=IZggQl19eQc/bLwl8EJKZRpfOzpSeVvJvNsjOF3z9K3dMaZ0ZSXFZczQFGIu2cvU4 VoLwxtLmN/RVREN4zKurrGYWPMe8aleYnYVqIfLDuBwvPpZjoSLb8El96o754vcaTA 7o91Z374W4NekjqvQkYAQGfhpfLVrcDA2kM16JBk= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Noah Goldstein To: glibc-cvs@sourceware.org Subject: [glibc] string: Add len=0 to {w}memcmp{eq} tests and benchtests X-Act-Checkin: glibc X-Git-Author: Noah Goldstein X-Git-Refname: refs/heads/master X-Git-Oldrev: 2e274cd8c1ebd0bd0c43a7f2e5433685740938ca X-Git-Newrev: ca7d181b62f703ae56b7be1e27428184560f68b4 Message-Id: <20221109043338.9E2873858D20@sourceware.org> Date: Wed, 9 Nov 2022 04:33:38 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=ca7d181b62f703ae56b7be1e27428184560f68b4 commit ca7d181b62f703ae56b7be1e27428184560f68b4 Author: Noah Goldstein Date: Sat Oct 29 15:19:57 2022 -0500 string: Add len=0 to {w}memcmp{eq} tests and benchtests len=0 is valid and fairly common so should be tested. Reviewed-by: Siddhesh Poyarekar Diff: --- benchtests/bench-memcmp.c | 18 +++++++++--------- string/test-memcmp.c | 16 ++++++++++------ 2 files changed, 19 insertions(+), 15 deletions(-) diff --git a/benchtests/bench-memcmp.c b/benchtests/bench-memcmp.c index d64eaa992e..b2816baebe 100644 --- a/benchtests/bench-memcmp.c +++ b/benchtests/bench-memcmp.c @@ -63,7 +63,7 @@ IMPL (MEMCMP, 1) static void do_one_test (json_ctx_t *json_ctx, impl_t *impl, const CHAR *s1, - const CHAR *s2, size_t len, int exp_result) + const CHAR *s2, size_t len) { size_t i, iters = INNER_LOOP_ITERS_LARGE; timing_t start, stop, cur; @@ -87,9 +87,6 @@ do_test (json_ctx_t *json_ctx, size_t align1, size_t align2, size_t len, size_t i; CHAR *s1, *s2; - if (len == 0) - return; - align1 &= (4096 - CHARBYTES); if (align1 + (len + 1) * CHARBYTES >= page_size) return; @@ -111,13 +108,16 @@ do_test (json_ctx_t *json_ctx, size_t align1, size_t align2, size_t len, for (i = 0; i < len; i++) s1[i] = s2[i] = 1 + (23 << ((CHARBYTES - 1) * 8)) * i % MAX_CHAR; - s1[len] = align1; - s2[len] = align2; - s2[len - 1] -= exp_result; + if (len) + { + s1[len] = align1; + s2[len] = align2; + s2[len - 1] -= exp_result; + } FOR_EACH_IMPL (impl, 0) { - do_one_test (json_ctx, impl, s1, s2, len, exp_result); + do_one_test (json_ctx, impl, s1, s2, len); } json_array_end (json_ctx); @@ -147,7 +147,7 @@ test_main (void) json_array_end (&json_ctx); json_array_begin (&json_ctx, "results"); - for (i = 1; i < 32; ++i) + for (i = 0; i < 32; ++i) { do_test (&json_ctx, i * CHARBYTES, i * CHARBYTES, i, 0); do_test (&json_ctx, i * CHARBYTES, i * CHARBYTES, i, 1); diff --git a/string/test-memcmp.c b/string/test-memcmp.c index 181b689f68..18d8b0d9f1 100644 --- a/string/test-memcmp.c +++ b/string/test-memcmp.c @@ -117,9 +117,6 @@ do_test (size_t align1, size_t align2, size_t len, int exp_result) size_t i; CHAR *s1, *s2; - if (len == 0) - return; - align1 &= (4096 - CHARBYTES); if (align1 + (len + 1) * CHARBYTES >= page_size) return; @@ -134,9 +131,16 @@ do_test (size_t align1, size_t align2, size_t len, int exp_result) for (i = 0; i < len; i++) s1[i] = s2[i] = 1 + (23 << ((CHARBYTES - 1) * 8)) * i % CHAR__MAX; - s1[len] = align1; - s2[len] = align2; - s2[len - 1] -= exp_result; + if (len) + { + s1[len] = align1; + s2[len] = align2; + s2[len - 1] -= exp_result; + } + else + { + exp_result = 0; + } FOR_EACH_IMPL (impl, 0) do_one_test (impl, s1, s2, len, exp_result);