From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1944) id C5E36384F486; Fri, 18 Nov 2022 11:35:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C5E36384F486 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1668771357; bh=DUdhdKvTN5vXvQIzgl+69hyfeYWprqsmc3g7Qgf+3y0=; h=From:To:Subject:Date:From; b=SrsRQuxIZvYganLfumvbMvDTgd59h8KAHyHhSv2i1tuQuzAAA98id2k4wA5igPN/7 82bffHgovWDts1JszaJZ+PkYGH6ZHB5lTKZkSK4HbgtQZaXKpTYldPLQzZ4FH/zPUg bDfqqKIEXlPnNio1p78qscxL6RleJb8N39urQhP8= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Szabolcs Nagy To: glibc-cvs@sourceware.org Subject: [glibc/arm/morello/main] cheri: Fix pselect signal mask argument X-Act-Checkin: glibc X-Git-Author: Szabolcs Nagy X-Git-Refname: refs/heads/arm/morello/main X-Git-Oldrev: f4c913ed552252ca91690e6c73ea02b10e263509 X-Git-Newrev: 187b3dd4263cccc0087df3c4311ded95d866d116 Message-Id: <20221118113557.C5E36384F486@sourceware.org> Date: Fri, 18 Nov 2022 11:35:57 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=187b3dd4263cccc0087df3c4311ded95d866d116 commit 187b3dd4263cccc0087df3c4311ded95d866d116 Author: Szabolcs Nagy Date: Thu Nov 17 15:19:10 2022 +0000 cheri: Fix pselect signal mask argument The signal mask argument is passed as a struct with a pointer and size in the linux syscall abi, but the types used in glibc were wrong for CHERI due to an x32 specific hack. Diff: --- sysdeps/unix/sysv/linux/pselect.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/sysdeps/unix/sysv/linux/pselect.c b/sysdeps/unix/sysv/linux/pselect.c index eba1c111f8..553de0a490 100644 --- a/sysdeps/unix/sysv/linux/pselect.c +++ b/sysdeps/unix/sysv/linux/pselect.c @@ -27,12 +27,19 @@ pselect64_syscall (int nfds, fd_set *readfds, fd_set *writefds, # define __NR_pselect6_time64 __NR_pselect6 #endif /* NB: This is required by ARGIFY used in x32 internal_syscallN. */ - __syscall_ulong_t data[2] = - { - (uintptr_t) sigmask, __NSIG_BYTES - }; +#ifdef __CHERI_PURE_CAPABILITY__ + typedef uintptr_t kernel_ptr_t; + typedef size_t kernel_size_t; +#else + typedef __syscall_ulong_t kernel_ptr_t; + typedef __syscall_ulong_t kernel_size_t; +#endif + struct { + kernel_ptr_t ptr; + kernel_size_t size; + } data = { (uintptr_t) sigmask, __NSIG_BYTES }; return SYSCALL_CANCEL (pselect6_time64, nfds, readfds, writefds, exceptfds, - timeout, data); + timeout, &data); } int