From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1944) id 1AB2B3853573; Wed, 23 Nov 2022 14:39:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1AB2B3853573 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1669214366; bh=Ds20zHLRNycvjCXUOHxYAZctNlzUg/pOgMKpEH+Px2o=; h=From:To:Subject:Date:From; b=JwnpRauc6WCFuGRQHjrqmFYCtMO7YZxPyFUq++CJH7kG5Z2CiPgDznahUR96Yt0zN GDHalvpPZl8CF2/sfUXkE3hES26nINUET2FO3dFhmHwwFsgrdvMbwDD60NxprZDTZr 61C+yxuMuJ2DAtoq+Y9Mzsmtc0drtOJHWTbl1m4g= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Szabolcs Nagy To: glibc-cvs@sourceware.org Subject: [glibc/arm/morello/main] elf: Fix alloca size in _dl_debug_vdprintf X-Act-Checkin: glibc X-Git-Author: Szabolcs Nagy X-Git-Refname: refs/heads/arm/morello/main X-Git-Oldrev: 8491c1adc9686641653cb9fb29a8d51ef349933c X-Git-Newrev: eee747d8cce17473ae3312ce6818253d4222c251 Message-Id: <20221123143926.1AB2B3853573@sourceware.org> Date: Wed, 23 Nov 2022 14:39:26 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=eee747d8cce17473ae3312ce6818253d4222c251 commit eee747d8cce17473ae3312ce6818253d4222c251 Author: Szabolcs Nagy Date: Tue Oct 11 14:22:35 2022 +0100 elf: Fix alloca size in _dl_debug_vdprintf The alloca size did not consider the optional width parameter for padding which could cause buffer underflow. The width is currently used e.g. by _dl_map_object_from_fd which passes 2 * sizeof(void *) which can be larger than the alloca buffer size on targets where sizeof(void *) >= 2 * sizeof(unsigned long). Even if large width is not used on existing targets it is better to fix the formatting code to avoid surprises. Diff: --- elf/dl-printf.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/elf/dl-printf.c b/elf/dl-printf.c index d3264ba96c..10efa925bd 100644 --- a/elf/dl-printf.c +++ b/elf/dl-printf.c @@ -163,8 +163,11 @@ _dl_debug_vdprintf (int fd, int tag_p, const char *fmt, va_list arg) /* We use alloca() to allocate the buffer with the most pessimistic guess for the size. Using alloca() allows having more than one integer formatting in a call. */ - char *buf = (char *) alloca (1 + 3 * sizeof (unsigned long int)); - char *endp = &buf[1 + 3 * sizeof (unsigned long int)]; + int size = 1 + 3 * sizeof (unsigned long int); + if (width + 1 > size) + size = width + 1; + char *buf = (char *) alloca (size); + char *endp = &buf[size]; char *cp = _itoa (num, endp, *fmt == 'x' ? 16 : 10, 0); /* Pad to the width the user specified. */