From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1944) id 8A5D73852C64; Wed, 23 Nov 2022 14:46:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8A5D73852C64 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1669214819; bh=pc05xruNhH4sDqHcUyjzyL6DxcCed6IogX5dzS6s7W0=; h=From:To:Subject:Date:From; b=BiWPIiqVaw+xO8jp3EDhnXEaPHlWSyJ93sS/BZcMdBQByMjFHia+W/VzwfsN+gKIg 8SOPOqvJlSOkVfUu56ZpUysAfhbU40fGjTXAXdiRmpxYUEmXijZZF0Y6JTswLFg4Cb Ilb4jJJSAhJF/OMNMuGqLrMAqr4iuz7uIZsHy5/o= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Szabolcs Nagy To: glibc-cvs@sourceware.org Subject: [glibc/arm/morello/main] cheri: malloc: Ensure the mappings have RW permission X-Act-Checkin: glibc X-Git-Author: Szabolcs Nagy X-Git-Refname: refs/heads/arm/morello/main X-Git-Oldrev: 3244a1fc1981694d582d7afbdc7e8e283530d485 X-Git-Newrev: 8b79bc92fab1cd4a8443cdcd3f9e313091d8bd62 Message-Id: <20221123144659.8A5D73852C64@sourceware.org> Date: Wed, 23 Nov 2022 14:46:59 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=8b79bc92fab1cd4a8443cdcd3f9e313091d8bd62 commit 8b79bc92fab1cd4a8443cdcd3f9e313091d8bd62 Author: Szabolcs Nagy Date: Fri Oct 21 12:35:33 2022 +0100 cheri: malloc: Ensure the mappings have RW permission The arena allocator incrementally applies RW mprotect to a PROT_NONE mapping. Use PROT_MAX to ensure the pointers derived from the original mapping have RW capability permission. Diff: --- malloc/malloc.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/malloc/malloc.c b/malloc/malloc.c index 02df29d2ad..701adbebca 100644 --- a/malloc/malloc.c +++ b/malloc/malloc.c @@ -1134,8 +1134,16 @@ static mchunkptr mremap_chunk(mchunkptr p, size_t new_size); # define MAP_NORESERVE 0 #endif +/* Allow RW mprotect later, on CHERI this means RW capability permission. */ +#ifdef PROT_MAX +# define PROT_MAX_RW PROT_MAX (PROT_READ | PROT_WRITE) +#else +# define PROT_MAX_RW 0 +#endif + #define MMAP(addr, size, prot, flags) \ - __mmap((addr), (size), (prot), (flags)|MAP_ANONYMOUS|MAP_PRIVATE, -1, 0) + __mmap((addr), (size), (prot)|PROT_MAX_RW, \ + (flags)|MAP_ANONYMOUS|MAP_PRIVATE, -1, 0) /*